Repository navigation
Refuse a 0-row matrix in DBSCAN::predict - #7
Merged
Merged
Conversation
DBSCAN::predict now returns EmptyInput for a matrix with 0 rows, as every other model does. Before, it returned an empty array, and it skipped the feature-count check for that matrix. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
DBSCAN::predictreturns an empty array for a matrix with 0 rows. Every other model returnsEmptyInput. The early return also comes before the feature-count check. A 0-row matrix with the wrong feature count therefore returnsOk, where it should return an error.Reproduction
Output on
master:Fix
This PR removes the early return, so
predictgoes throughvalidate_predict_inputlike every other model. This is a behavior change, andCHANGELOG.mdmarks it as one. A fit that finds no core point still stores a(0, n_features)matrix, so the feature-count check stays correct for that model.Output on this branch: