Skip to content

fix(website): center home promo close icon - #989

Merged
ppapsmoken merged 1 commit into
mainfrom
codex/fix-home-popup-close-centering
Aug 31, 2026
Merged

fix(website): center home promo close icon#989
ppapsmoken merged 1 commit into
mainfrom
codex/fix-home-popup-close-centering

Conversation

@ppapsmoken

Copy link
Copy Markdown
Collaborator

Problem / background

首页欢迎优惠弹窗右上角关闭符号使用文本 ×,在不同字体和浏览器中会受字形基线影响,视觉上无法在按钮内上下左右居中。

Evidence

本地首页 http://localhost:4000/ 的弹窗中可复现;替换为 SVG 图标后,浏览器测得图标与按钮中心的水平、垂直偏差均为 0px。

Root cause

文本 × 的字形包围盒不等于按钮内容盒,leading-none 不能消除字体基线偏移。

Scope / design

仅修改 website/src/components/welcome-promo-modal.tsx:使用现有 lucide-reactX 图标,保留按钮的 flex 居中布局并移除默认内边距。弹窗状态、关闭交互、文案和路由均不变。

Impact / risks

仅影响官网 newapi-web 首页优惠弹窗的关闭按钮呈现;不涉及 Go 控制台、router、数据库或基础设施。风险低。

Validation / acceptance

  • bun test src/components/welcome-promo-modal.test.ts
  • bun run typecheck
  • bun run lint(仅现有 <img> 性能 warning)
  • bun run build
  • 本地首页弹窗可见,关闭图标几何居中

合并后请由 website workflow 部署 newapi-web

@ppapsmoken
ppapsmoken merged commit 5a2da74 into main Aug 31, 2026
1 check passed
@ppapsmoken
ppapsmoken deleted the codex/fix-home-popup-close-centering branch August 31, 2026 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant