-
Notifications
You must be signed in to change notification settings - Fork 1
Feature/shape terrain #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
1ce5ec0
partial changes
Sofistico 2979e04
adding dig spell
Sofistico 66dcbe3
some small changes to make the dig spell better suited for digging
Sofistico b0a60f0
raise wall effect and some small changes
Sofistico efd5074
Better look window handling
Sofistico e5b08bb
new gorogue version
Sofistico ab56032
fixing indentention
Sofistico 856f394
fixing error with the dotnet test
Sofistico 7466e25
some work on stuff in regards to the haste component and addmessagelo…
Sofistico 5399f08
fixing the sonar stuff
Sofistico 212e45e
fxing sonar
Sofistico a1c818f
fix sonar
Sofistico 8f9b4c1
fix sonar
Sofistico 2ed822a
fix blink spell
Sofistico File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| dotnet build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| dotnet run --project ./src/MagiRogue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| [ | ||
| { | ||
| "Id": "raise_wall", | ||
| "ShapingAbility": "Mana Shaping", | ||
| "Name": "Raise wall", | ||
| "SpellLevel": 2, | ||
| "Description": "This spell raises a wall at the desired location, it uses the material found on the floor to raise this wall", | ||
| "SpellRange": 4, | ||
| "MagicCost": 7, | ||
| "MagicArt": "Alteration", | ||
| "Effects": [ | ||
| { | ||
| "AreaOfEffect": "Target", | ||
| "EffectType": "RAISEWALL", | ||
| "TargetsTile": true, | ||
| "IgnoresWall": true | ||
| } | ||
| ], | ||
| "Manifestation": "Instant", | ||
| "Context": ["Terraforming", "BlocksSight"] | ||
| }, | ||
| { | ||
| "Id": "dig", | ||
| "ShapingAbility": "Mana Shaping", | ||
| "Name": "Dig", | ||
| "SpellLevel": 2, | ||
| "Description": "This spell transmutates the targeted wall into rubble", | ||
| "SpellRange": 4, | ||
| "MagicCost": 7, | ||
| "MagicArt": "Alteration", | ||
| "Effects": [ | ||
| { | ||
| "AreaOfEffect": "Target", | ||
| "EffectType": "DIG", | ||
| "TargetsTile": true, | ||
| "IgnoresWall": true | ||
| } | ||
| ], | ||
| "Manifestation": "Instant", | ||
| "Context": ["Terraforming", "Dig"] | ||
| } | ||
| ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,6 +14,9 @@ public enum SpellContext | |
| Buff, | ||
| Debuff, | ||
| Teleport, | ||
| Distance | ||
| Distance, | ||
| Terraforming, | ||
| Dig, | ||
| BlocksSight, | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,8 +2,9 @@ | |
| { | ||
| public enum TargetState | ||
| { | ||
| IdleMode, | ||
| LookMode, | ||
| TargetingSpell, | ||
| TargetingItem, | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Beware the null-forgiving operator, young apprentice!
The null-forgiving operator
!is used onitem.Massafter checkingif (sucess), but the success condition doesn't guarantee thatitemis non-null. TheEndItemTargetting()method could return success with a null item in edge cases.Apply this enchantment to ensure safe access:
📝 Committable suggestion
🤖 Prompt for AI Agents