fix(ci): update stale .mjs references after .mts rename and drop Node 20

jdalton · jdalton · commit 8de06699efaf · 2026-04-15T12:53:01.000-04:00
The scripts/*.mjs to *.mts rename missed updating internal cross-references
in scripts, tests, and registry build files, causing ERR_MODULE_NOT_FOUND
on all CI jobs. Also removes Node 20 from the CI matrix since it cannot
run .mts files natively, fixes TypeScript errors in test-imported scripts,
and excludes scripts/ from tsconfig to avoid 1000+ pre-existing type errors.
diff --git a/.github/workflows/_local-not-for-reuse-ci.yml b/.github/workflows/_local-not-for-reuse-ci.yml
@@ -22,7 +22,7 @@ jobs:
       fail-fast: false
       lint-script: 'pnpm run lint --all'
       lint-setup-script: 'pnpm run build'
-      node-versions: '[20, 22, 24]'
+      node-versions: '[22, 24]'
       os-versions: '["ubuntu-latest", "windows-latest"]'
       test-script: 'pnpm run test --all --fast'
       test-setup-script: 'pnpm run build'
diff --git a/registry/scripts/build.mjs b/registry/scripts/build.mjs
@@ -18,8 +18,8 @@ import {
   buildConfig,
   watchConfig,
 } from '../.config/esbuild.config.mjs'
-import { parseArgs } from '../../scripts/utils/parse-args.mjs'
-import { runSequence } from '../../scripts/utils/run-command.mjs'
+import { parseArgs } from '../../scripts/utils/parse-args.mts'
+import { runSequence } from '../../scripts/utils/run-command.mts'
 import process from 'node:process'
 
 const logger = getDefaultLogger()
diff --git a/scripts/check.mts b/scripts/check.mts
@@ -88,49 +88,49 @@ async function main(): Promise<void> {
         },
       },
       {
-        args: ['scripts/validation/no-link-deps.mjs'],
+        args: ['scripts/validation/no-link-deps.mts'],
         command: 'node',
         options: {
           ...(process.platform === 'win32' && { shell: true }),
         },
       },
       {
-        args: ['scripts/validation/bundle-deps.mjs'],
+        args: ['scripts/validation/bundle-deps.mts'],
         command: 'node',
         options: {
           ...(process.platform === 'win32' && { shell: true }),
         },
       },
       {
-        args: ['scripts/validation/esbuild-minify.mjs'],
+        args: ['scripts/validation/esbuild-minify.mts'],
         command: 'node',
         options: {
           ...(process.platform === 'win32' && { shell: true }),
         },
       },
       {
-        args: ['scripts/validation/no-cdn-refs.mjs'],
+        args: ['scripts/validation/no-cdn-refs.mts'],
         command: 'node',
         options: {
           ...(process.platform === 'win32' && { shell: true }),
         },
       },
       {
-        args: ['scripts/validation/markdown-filenames.mjs'],
+        args: ['scripts/validation/markdown-filenames.mts'],
         command: 'node',
         options: {
           ...(process.platform === 'win32' && { shell: true }),
         },
       },
       {
-        args: ['scripts/validation/file-size.mjs'],
+        args: ['scripts/validation/file-size.mts'],
         command: 'node',
         options: {
           ...(process.platform === 'win32' && { shell: true }),
         },
       },
       {
-        args: ['scripts/validation/file-count.mjs'],
+        args: ['scripts/validation/file-count.mts'],
         command: 'node',
         options: {
           ...(process.platform === 'win32' && { shell: true }),
diff --git a/scripts/constants/env.mts b/scripts/constants/env.mts
@@ -5,7 +5,7 @@
 /**
  * Get environment configuration with inlined values.
  */
-function envAsBoolean(value) {
+function envAsBoolean(value: string | undefined): boolean {
   if (typeof value === 'string') {
     const lower = value.toLowerCase()
     return lower === 'true' || lower === '1'
@@ -20,8 +20,8 @@ export function getEnv() {
   const { env } = process
   return Object.freeze({
     __proto__: null,
-    CI: envAsBoolean(env.CI),
-    NODE_ENV: env.NODE_ENV,
-    VERBOSE_BUILD: envAsBoolean(env.VERBOSE_BUILD),
+    CI: envAsBoolean(env['CI']),
+    NODE_ENV: env['NODE_ENV'],
+    VERBOSE_BUILD: envAsBoolean(env['VERBOSE_BUILD']),
   })
 }
diff --git a/scripts/cover.mts b/scripts/cover.mts
@@ -49,7 +49,7 @@ logger.log('')
 
 // Rebuild with source maps enabled for coverage
 logger.info('Building with source maps for coverage...')
-const buildResult = await spawn('node', ['scripts/build.mjs'], {
+const buildResult = await spawn('node', ['scripts/build.mts'], {
   cwd: rootPath,
   stdio: 'inherit',
   env: envWithMemoryLimits,
diff --git a/scripts/npm/make-npm-override.mts b/scripts/npm/make-npm-override.mts
@@ -271,8 +271,8 @@ async function main(): Promise<void> {
   const tsRefs = []
   if (isEsShim) {
     const { default: maintainedNodeVersions } =
-      await import('../constants/node.mjs')
-    const { PACKAGE_DEFAULT_NODE_RANGE } = await import('../constants/node.mjs')
+      await import('../constants/node.mts')
+    const { PACKAGE_DEFAULT_NODE_RANGE } = await import('../constants/node.mts')
     const parts = origPkgName
       .split(/[-.]/)
       .filter(p => p !== 'es' && p !== 'helpers')
@@ -405,7 +405,7 @@ async function main(): Promise<void> {
   // First copy the template directory contents to the package path.
   await fs.cp(templatePkgPath, pkgPath, { recursive: true })
   // Then modify the new package's package.json source and write to disk.
-  const { PACKAGE_DEFAULT_NODE_RANGE } = await import('../constants/node.mjs')
+  const { PACKAGE_DEFAULT_NODE_RANGE } = await import('../constants/node.mts')
   await writeAction(
     await getPackageJsonAction(pkgPath, {
       engines: {
diff --git a/scripts/npm/publish-npm-packages.mts b/scripts/npm/publish-npm-packages.mts
@@ -318,7 +318,7 @@ async function publishAtCommit(sha) {
 
   // Update manifest.json with latest published versions before publishing registry.
   if (registryPkgToPublish && !fails.includes(registryPkgToPublish.printName)) {
-    await spawn('node', ['scripts/update-manifest.mjs', '--force'], {
+    await spawn('node', ['scripts/npm/update-manifest.mts', '--force'], {
       shell: WIN32,
     })
 
diff --git a/scripts/npm/test-npm-packages.mts b/scripts/npm/test-npm-packages.mts
@@ -69,10 +69,10 @@ async function main(): Promise<void> {
     scriptDir,
     '..',
     'validation',
-    'npm-packages.mjs',
+    'npm-packages.mts',
   )
-  const installScript = path.join(scriptDir, 'install-npm-packages.mjs')
-  const testScript = path.join(scriptDir, 'run-npm-package-tests.mjs')
+  const installScript = path.join(scriptDir, 'install-npm-packages.mts')
+  const testScript = path.join(scriptDir, 'run-npm-package-tests.mts')
 
   // Build common arguments.
   const commonArgs = []
diff --git a/scripts/test.mts b/scripts/test.mts
@@ -281,7 +281,7 @@ async function runTests(
 
   // Use interactive runner for interactive Ctrl+O experience when appropriate
   if (process.stdout.isTTY) {
-    const { runTests } = await import('./utils/interactive-runner.mjs')
+    const { runTests } = await import('./utils/interactive-runner.mts')
     return runTests(vitestPath, vitestArgs, {
       env: spawnOptions.env,
       cwd: spawnOptions.cwd,
diff --git a/scripts/testing/reproduce-ci-locally.mts b/scripts/testing/reproduce-ci-locally.mts
@@ -200,7 +200,7 @@ async function runUnitTests(workDir) {
 async function runNpmPackageTests(workDir) {
   logger.info('\n--- Running NPM Package Tests (CI Mode) ---')
 
-  const args = ['scripts/test-npm-packages.mjs']
+  const args = ['scripts/npm/test-npm-packages.mts']
 
   if (cliArgs.package?.length) {
     cliArgs.package.forEach(pkg => {
diff --git a/scripts/utils/get-code-coverage.mts b/scripts/utils/get-code-coverage.mts
@@ -34,7 +34,7 @@ export async function getCodeCoverage(options) {
       return undefined
     }
 
-    const result = await spawn('node', ['scripts/cover.mjs'], {
+    const result = await spawn('node', ['scripts/cover.mts'], {
       stdio: 'ignore',
       shell: WIN32,
     })
diff --git a/scripts/utils/tests.mts b/scripts/utils/tests.mts
@@ -6,7 +6,7 @@
 import { parseArgs } from '@socketsecurity/lib/argv/parse'
 import process from 'node:process'
 
-let _cliArgs
+let _cliArgs: Record<string, unknown> | undefined
 
 /**
  * Parse and cache command line arguments.
@@ -38,17 +38,17 @@ function shouldRunTests() {
   const args = getCliArgs()
 
   // Always run in CI.
-  if (process.env.CI === 'true') {
+  if (process.env['CI'] === 'true') {
     return true
   }
 
   // Run if force flag is set.
-  if (args.force || process.env.FORCE_TEST === '1') {
+  if (args['force'] || process.env['FORCE_TEST'] === '1') {
     return true
   }
 
   // Run if not in pre-commit hook.
-  if (!process.env.PRE_COMMIT) {
+  if (!process.env['PRE_COMMIT']) {
     return true
   }
 
@@ -60,27 +60,23 @@ function shouldRunTests() {
  * Check if package testing should be skipped for a given package.
  * Package tests are skipped during pre-commit hooks to speed up commits.
  * They can be forced to run with --force flag or in CI environments.
- *
- * @param {string} _eco - Ecosystem (e.g., "npm")
- * @param {string} _packageName - Package name
- * @returns {boolean} True if package testing should be skipped
  */
-function isPackageTestingSkipped(_eco, _packageName) {
+function isPackageTestingSkipped(_eco: string, _packageName: string) {
   // In pre-commit hooks, skip package tests unless forced.
-  if (process.env.PRE_COMMIT === 'true') {
+  if (process.env['PRE_COMMIT'] === 'true') {
     const args = getCliArgs()
-    return !(args.force || process.env.FORCE_TEST === '1')
+    return !(args['force'] || process.env['FORCE_TEST'] === '1')
   }
 
   // Always run in CI.
-  if (process.env.CI === 'true') {
+  if (process.env['CI'] === 'true') {
     return false
   }
 
   // Skip by default in regular runs to keep tests fast.
   // Use --force flag to run package tests.
   const args = getCliArgs()
-  return !(args.force || process.env.FORCE_TEST === '1')
+  return !(args['force'] || process.env['FORCE_TEST'] === '1')
 }
 
 export { getCliArgs, isPackageTestingSkipped, shouldRunTests }
diff --git a/scripts/validation/no-cdn-refs.mts b/scripts/validation/no-cdn-refs.mts
@@ -116,7 +116,7 @@ async function findTextFiles(dir, files = []) {
  */
 async function checkFileForCdnRefs(filePath) {
   // Skip this validator script itself (it mentions CDN domains by necessity)
-  if (filePath.endsWith('no-cdn-refs.mjs')) {
+  if (filePath.endsWith('no-cdn-refs.mts')) {
     return []
   }
 
diff --git a/test/npm/hyrious__bun.lockb.test.mts b/test/npm/hyrious__bun.lockb.test.mts
@@ -4,7 +4,7 @@ import path from 'node:path'
 
 import { describe, expect, it } from 'vitest'
 
-import { TEST_NPM_FIXTURES_PATH } from '../../scripts/constants/paths.mjs'
+import { TEST_NPM_FIXTURES_PATH } from '../../scripts/constants/paths.mts'
 import { setupNpmPackageTest } from '../utils/npm-package-helper.mts'
 
 const UTF8 = 'utf8'
diff --git a/test/npm/json-stable-stringify.test.mts b/test/npm/json-stable-stringify.test.mts
@@ -1,7 +1,7 @@
 /** @fileoverview Tests for @socketregistry/json-stable-stringify npm package override. */
 import { describe, expect, it } from 'vitest'
 
-import { getEnv } from '../../scripts/constants/env.mjs'
+import { getEnv } from '../../scripts/constants/env.mts'
 import { setupNpmPackageTest } from '../utils/npm-package-helper.mts'
 
 const ENV = getEnv()
diff --git a/test/packages.test.mts b/test/packages.test.mts
@@ -28,12 +28,12 @@ import {
   NPM_PACKAGES_PATH,
   PACKAGE_JSON,
   SOCKET_REGISTRY_SCOPE,
-} from '../scripts/constants/paths.mjs'
+} from '../scripts/constants/paths.mts'
 import {
   getEcosystems,
   getNpmPackageNames,
-} from '../scripts/constants/testing.mjs'
-import { getIgnoreGlobs } from '../scripts/constants/utils.mjs'
+} from '../scripts/constants/testing.mts'
+import { getIgnoreGlobs } from '../scripts/constants/utils.mts'
 import process from 'node:process'
 
 const LICENSE_GLOB =
diff --git a/test/utils/npm-package-helper.mts b/test/utils/npm-package-helper.mts
@@ -5,8 +5,8 @@
 
 import path from 'node:path'
 
-import { NPM, NPM_PACKAGES_PATH } from '../../scripts/constants/paths.mjs'
-import { isPackageTestingSkipped } from '../../scripts/utils/tests.mjs'
+import { NPM, NPM_PACKAGES_PATH } from '../../scripts/constants/paths.mts'
+import { isPackageTestingSkipped } from '../../scripts/utils/tests.mts'
 
 interface SetupNpmPackageTestResult {
   eco: string
diff --git a/tsconfig.json b/tsconfig.json
@@ -38,7 +38,7 @@
   "include": ["**/*.ts", "**/*.mts", "**/*.cts"],
   "exclude": [
     "**/node_modules/**/*",
-    "scripts/templates/**/*",
+    "scripts/**/*",
     "test/**/packages/**/*",
     "test/npm/node_modules/**",
     "test/npm/**/*.d.ts"
