chore: remove redundant catch type annotations (useUnknownInCatchVariables is enabled)

Author: jdalton

scripts/check.mts

@@ -148,7 +148,7 @@ async function main(): Promise<void> {
       logger.success('All checks passed')
       printFooter()
     }
-  } catch (error: unknown) {
+  } catch (error) {
     logger.error(`Check failed: ${error.message}`)
     process.exitCode = 1
   }

scripts/ci/inline-action-versions-as-shas.mts

@@ -90,7 +90,7 @@ async function processFile(filePath, token, dryRun) {
     try {
       const sha = await resolveRefToSha(owner, repo, ref, { token })
       depMap.set(`${owner}/${repoPath}@${ref}`, { owner, ref, repoPath, sha })
-    } catch (e: unknown) {
+    } catch (e) {
       logger.error(
         `Failed to resolve ${owner}/${repoPath}@${ref}: ${e.message}`,
       )

scripts/clean.mts

@@ -63,7 +63,7 @@ async function cleanDirectories(
           logger.done(`Cleaned ${name} (already clean)`)
         }
       }
-    } catch (error: unknown) {
+    } catch (error) {
       if (!quiet) {
         logger.error(`Failed to clean ${name}`)
         logger.error(error.message)
@@ -211,7 +211,7 @@ async function main(): Promise<void> {
         logger.success('Clean completed successfully!')
       }
     }
-  } catch (error: unknown) {
+  } catch (error) {
     logger.error(`Clean runner failed: ${error.message}`)
     process.exitCode = 1
   }

scripts/cover.mts

@@ -305,7 +305,7 @@ try {
   }
 
   process.exitCode = exitCode
-} catch (error: unknown) {
+} catch (error) {
   logger.error(`Coverage script failed: ${error.message}`)
   process.exitCode = 1
 }

scripts/fix.mts

@@ -41,7 +41,7 @@ async function run(
       logger.warn(`${label || cmd}: exited ${result.code} (non-blocking)`)
     }
     return 0
-  } catch (e: unknown) {
+  } catch (e) {
     if (!required) {
       logger.warn(`${label || cmd}: ${e.message} (non-blocking)`)
       return 0

scripts/lint.mts

@@ -468,7 +468,7 @@ async function main(): Promise<void> {
         logger.success('All lint checks passed!')
       }
     }
-  } catch (error: unknown) {
+  } catch (error) {
     logger.error(`Lint runner failed: ${error.message}`)
     process.exitCode = 1
   }

scripts/maintenance/update-caniuse-lite.mts

@@ -35,7 +35,7 @@ async function main(): Promise<void> {
     }
 
     logger.log('Done')
-  } catch (e: unknown) {
+  } catch (e) {
     logger.fail(`update caniuse-lite: ${e.message}`)
     process.exitCode = 1
   }

scripts/npm/check-trusted-packages.mts

@@ -89,7 +89,7 @@ async function runCommand(command, args = []) {
       )
     }
     return result.stdout
-  } catch (e: unknown) {
+  } catch (e) {
     throw new Error(`Command failed: ${e.message}`)
   }
 }
@@ -226,7 +226,7 @@ async function getPackagesFromManifest() {
     }
 
     return Array.from(packages).sort()
-  } catch (error: unknown) {
+  } catch (error) {
     logger.error('Failed to read manifest.json:', error.message)
     return []
   }
@@ -242,7 +242,7 @@ async function getPackagesFromScope(scope) {
     ])
     const results = JSON.parse(output)
     return results.map(pkg => pkg.name)
-  } catch (error: unknown) {
+  } catch (error) {
     logger.error(`Failed to search for ${scope} packages:`, error.message)
     return []
   }
@@ -316,7 +316,7 @@ async function main(): Promise<void> {
       } else {
         results.failed.push(packageName)
       }
-    } catch (error: unknown) {
+    } catch (error) {
       if (args.debug) {
         logger.groupEnd()
       }

scripts/npm/install-npm-packages.mts

@@ -208,7 +208,7 @@ async function getWorkspaceCacheVersion() {
     cachedWorkspaceCacheVersion =
       actionYaml?.inputs?.['cache-version']?.default || 'v1'
     return cachedWorkspaceCacheVersion
-  } catch (e: unknown) {
+  } catch (e) {
     logger.warn(
       `Could not read cache version from action.yml: ${e.message}. Using fallback 'v1'.`,
     )
@@ -647,7 +647,7 @@ async function installPackage(packageInfo) {
                 editable: true,
               })
               break
-            } catch (error: unknown) {
+            } catch (error) {
               lastError = error
               if (attempt < JSON_PARSE_MAX_RETRIES) {
                 // Wait longer on each retry (200ms, 400ms).
@@ -720,7 +720,7 @@ async function installPackage(packageInfo) {
           packageSpec = pathToFileURL(repackedTarball).href
           modifiedPackagePath = tempExtractDir
         }
-      } catch (e: unknown) {
+      } catch (e) {
         // If extraction fails, fall back to the original GitHub URL.
         logger.warn(
           `Warning: Could not extract GitHub tarball for ${origPkgName}, using URL directly: ${e.message}`,
@@ -1023,7 +1023,7 @@ async function installPackage(packageInfo) {
       installed: true,
       tempDir: packageTempDir,
     }
-  } catch (error: unknown) {
+  } catch (error) {
     // Clean up temporary GitHub tarball extraction directory.
     if (modifiedPackagePath) {
       try {
@@ -1118,7 +1118,7 @@ async function main(): Promise<void> {
     if (!Array.isArray(downloadResults)) {
       throw new Error('Download results must be an array')
     }
-  } catch (error: unknown) {
+  } catch (error) {
     logger.fail(`Could not read download results: ${error.message}`)
     if (error instanceof SyntaxError) {
       logger.fail(

scripts/npm/make-npm-override.mts

@@ -485,7 +485,7 @@ async function main(): Promise<void> {
     if (!cliArgs.quiet) {
       logger.log('Finished 🎉')
     }
-  } catch (e: unknown) {
+  } catch (e) {
     logger.fail('Package override finalization encountered an error:')
     logger.error(e)
   }