Large rework - #9
Open
maxkurze1 wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey Tony (@tonai),
I quite like your progress bar component, thanks for your work. However, it was missing a bunch of options for my use case. Now, unfortunately, when implementing these features it just happened that I went from one to next without cleanly separating them into atomic commits. As a result, this PR probably contains way too much stuff at once and is a hell to review, I am honestly sorry about that. Nevertheless, I would still like to see these changes merged and prevent the maintenance of multiple forks (once it is merged I am also happy to help maintain your repo)
Alright about the features:
new options
emptyFirstfillLastclicksdisable"cover"and"end"layouts - now that is the default but may be configuredprintfadeBesides those changes I also moved the marker-visuals into separate components which are embedded through a slot. This enables users to define their own markers + enables the library to support multiple marker types out of the box
Lastly, I also added a
scaleoption that configures whether each slide should get the same progress-portion or if it should be distributed based on the number of clicks (which represents the actual progress of my presentations much closer)Unfortunately some of these changes are breaking changes. Specifically, the default
<Progress />now needs to be replaced by
to achieve the same result.
Please tell me what you think of these changes and what would be necessary to get them merged. I am happy to help.