misc#330
Merged
Merged
Conversation
OpenCode notices that the argument to CLZ could evaluate to 0, leading to UB. The follow on problem here is that even if it were not, this still leads to an invalid large `INITIAL_SET_SIZE_EXPONENT`. The effect of this would be for `--set-capacity x` where `x` is a small number to generate code that would malfunction at runtime. Reported-by: OpenCode 1.16.2
Reported-by: OpenCode 1.16.2
OpenCode complains that the shift in this function could be out-of-range. This is a false positive, seemingly influenced by other incorrect inferences OpenCode makes about this file. But lets try to guide static analysis tools like this to something more accurate. Reported-by: OpenCode 1.16.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.