Skip to content

ci(release): mirror registry workflows to public - #246

Merged
suchintan merged 6 commits into
mainfrom
repo-sync/rustwright-cloud-230
Aug 24, 2026
Merged

suchintan merged 6 commits into
mainfrom
repo-sync/rustwright-cloud-230

Conversation

@suchintan

Copy link
Copy Markdown
Member

@suchintan suchintan added the sync Automated cross-repository sync label Aug 24, 2026
@claude

claude Bot commented Aug 24, 2026

Copy link
Copy Markdown

Summary
CI-only change: consolidates five duplicated inline zig-cc linker wrapper scripts into the existing shared tools/zig-cc, renames ZIG_TARGET to CARGO_ZIG_TARGET consistently, wires up the (previously missing) zig linker config in release-mcp-npm.yml, and adds a fork-safety publish gate there. No Rust/Python/Node source touched, so the CDP/FFI/API-compat/anti-detection review criteria do not apply here — this is a build-reliability improvement and a net reduction in duplicated bash.

🔴 Critical Issues (0)

None found.

🟡 Suggestions (2)
  • release-pypi.yml: the aarch64 row now sets CC_aarch64_unknown_linux_gnu / CARGO_TARGET_AARCH64_UNKNOWN_LINUX_GNU_LINKER to the pinned tools/zig-cc, in addition to passing --zig to maturin-action. Maturin's own --zig flag also arranges a zig-cc wrapper internally for cross builds. Worth confirming in CI that the manually-set env vars take precedence over (or do not conflict with) maturin's built-in zig handling for this target, since this combination is new for the pypi workflow (the other four workflows use plain cargo/cargo zigbuild, not maturin).
  • release-mcp-npm.yml still only triggers on tag push (no workflow_dispatch/dry-run input like its siblings release-npm.yml/release-pypi.yml). That means the new Configure Linux linker step, needed for the zig cross-builds to pick up the right C compiler for C deps like ring, can only be exercised by cutting a real mcp-npm-v* release tag. Consider adding a dry-run workflow_dispatch path so this can be validated ahead of an actual release.
📝 Minor / Style (1)
  • The target_env/cc_env derivation (tr upper/lower and dash-to-underscore) is still copy-pasted across release-gem.yml, release-maven.yml, release-npm.yml, and release-nuget.yml. Since this PR already centralized the linker script itself, it might be worth also factoring these two lines into a small composite action (or a helper script alongside tools/zig-cc) to finish the DRY-up.

@suchintan
suchintan merged commit 769674b into main Aug 24, 2026
14 of 16 checks passed
@suchintan
suchintan deleted the repo-sync/rustwright-cloud-230 branch August 24, 2026 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sync Automated cross-repository sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant