Redact sensitive FreshRSS login failure logs - #20
Closed
Skulldorom wants to merge 1 commit into
Closed
Conversation
Owner
Author
|
Superseded by #25 — all four PRs merged with conflict resolution and review fixes applied. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
urlsplitinmain.py.get_greader_token().caplogregression testtest_get_greader_token_rejects_failed_login_without_logging_secretsintests/test_main.pythat asserts the status and upstream host are present in logs and that sentinel credentials, response body, and token values are never logged.Testing
uv run pytest -q, which completed successfully with9 passed.pytest -qdirectly in the environment failed during collection due tofastapinot being installed globally, which is an environment issue and not related to the changes.git diff --checkto validate the diff for formatting issues and it reported no problems.Codex Task