Skip to content

Require explicit FreshRSS host and credentials; remove localhost fallback - #19

Merged
Skulldorom merged 1 commit into
mainfrom
codex/remove-localhost-fallback-and-update-documentation
Jul 20, 2026
Merged

Require explicit FreshRSS host and credentials; remove localhost fallback#19
Skulldorom merged 1 commit into
mainfrom
codex/remove-localhost-fallback-and-update-documentation

Conversation

@Skulldorom

Copy link
Copy Markdown
Owner

Motivation

  • Prevent containers from entering a restart loop when FreshRSS connection info is missing by failing early with a clear error.
  • Remove the unsafe http://localhost:8020 fallback which is not reachable from inside the container in most deployments.
  • Provide documentation and examples for common deployment networking patterns so users can choose the correct host value.

Description

  • Updated docker-compose.yml to require FRESHRSS_HOST, FRESHRSS_USER, and FRESHRSS_PASS using Compose interpolation (${FRESHRSS_HOST:?...}) so missing or empty values produce a clear error before container creation.
  • Replaced the http://localhost:8020 default with explicit guidance and examples in .env.example, adding options for a same-project Compose service, Docker Desktop (host.docker.internal), and Linux host addresses (or host-gateway mapping).
  • Expanded README.md with instructions explaining that FRESHRSS_HOST must be reachable from the API container and added illustrative Compose and .env snippets for the three deployment cases.
  • Clarified docker compose usage in the README and replaced ambiguous examples that encouraged using localhost from inside containers.

Testing

  • Ran git diff --check with no issues reported.
  • Ran the test suite with uv run pytest and all tests passed (9 passed).
  • Attempted to validate Docker Compose behavior (docker compose config) but Compose/Docker was not available in the execution environment so validation could not be executed here.

Codex Task

@Skulldorom
Skulldorom merged commit 6dee102 into main Jul 20, 2026
2 checks passed
@Skulldorom
Skulldorom deleted the codex/remove-localhost-fallback-and-update-documentation branch July 20, 2026 09:41

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7b312a9452

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread README.md
FRESHRSS_PASS: ${FRESHRSS_PASS:?Set FRESHRSS_PASS in .env}
```

Equivalently, keep the provided Compose file and set this in `.env`:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Add FreshRSS before using its service hostname

This “equivalent” setup fails when a user keeps the provided Compose file: docker-compose.yml defines only custom-api and joins no external network, so Docker DNS cannot resolve the freshrss hostname. This option must also instruct the user to add the FreshRSS service to that Compose project or attach both containers to a shared network; changing only .env causes every FreshRSS request to fail.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant