Require explicit FreshRSS host and credentials; remove localhost fallback - #19
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7b312a9452
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| FRESHRSS_PASS: ${FRESHRSS_PASS:?Set FRESHRSS_PASS in .env} | ||
| ``` | ||
|
|
||
| Equivalently, keep the provided Compose file and set this in `.env`: |
There was a problem hiding this comment.
Add FreshRSS before using its service hostname
This “equivalent” setup fails when a user keeps the provided Compose file: docker-compose.yml defines only custom-api and joins no external network, so Docker DNS cannot resolve the freshrss hostname. This option must also instruct the user to add the FreshRSS service to that Compose project or attach both containers to a shared network; changing only .env causes every FreshRSS request to fail.
Useful? React with 👍 / 👎.
Motivation
http://localhost:8020fallback which is not reachable from inside the container in most deployments.Description
docker-compose.ymlto requireFRESHRSS_HOST,FRESHRSS_USER, andFRESHRSS_PASSusing Compose interpolation (${FRESHRSS_HOST:?...}) so missing or empty values produce a clear error before container creation.http://localhost:8020default with explicit guidance and examples in.env.example, adding options for a same-project Compose service, Docker Desktop (host.docker.internal), and Linux host addresses (orhost-gatewaymapping).README.mdwith instructions explaining thatFRESHRSS_HOSTmust be reachable from the API container and added illustrative Compose and.envsnippets for the three deployment cases.docker composeusage in the README and replaced ambiguous examples that encouraged usinglocalhostfrom inside containers.Testing
git diff --checkwith no issues reported.uv run pytestand all tests passed (9 passed).docker compose config) but Compose/Docker was not available in the execution environment so validation could not be executed here.Codex Task