Bound unread item query count - #18
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f4b57ef9c1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| [dependency-groups] | ||
| dev = [ | ||
| "httpx2>=2.0.0", |
There was a problem hiding this comment.
Regenerate the lockfile for the new test dependency
The checked workflow .github/workflows/docker.yml installs with uv sync --frozen before running pytest; uv sync --help defines --frozen as “Sync without updating the uv.lock file.” Because this commit does not add httpx2 to uv.lock, that install omits it, and the new from fastapi.testclient import TestClient fails during collection with Starlette's RuntimeError requiring httpx2. Update and commit uv.lock so the test job can run.
Useful? React with 👍 / 👎.
Motivation
nrange explicit in the documentation for dashboard authors and operators.Description
nquery parameter infreshrss_unreadwithQuery(default=10, ge=1, le=100)inmain.py.README.mdto document the validnrange as1–100for the/freshrss/unreadendpoint.tests/test_main.pythat usefastapi.testclient.TestClientto verify out-of-range values (0and101) return HTTP 422 without contacting FreshRSS and that boundary values (1and100) are accepted and forwarded.httpx2to the development dependency group inpyproject.tomlto satisfyTestClient's transport requirement.Testing
python -m py_compile main.py tests/test_main.pyran successfully and reported no syntax errors.git diff --checkwas run and reported no issues.uv run pytestattempted test collection but failed becausestarlette.testclientrequires thehttpx2package;httpx2was added to thedevdependencies, however installation could not be completed in this environment due to inability to fetch packages from PyPI, so pytest could not complete here.Codex Task