Repository navigation
Island to another screen, B.O.T.S's face by default, agent swap from the deck - #51
Merged
Merged
Conversation
…ost its release Since v0.1.17 the carried island's window spanned only its own screen, so it could no longer be taken to another one. The pointer watch now takes the span to the screen under the pointer (island::follow_span, screen_at) and tells the page (companion://span); the island lands on that screen's nearest place, and the screen is saved with the place (landPatch). The island stays held where it was taken, measured in the window as it is now. A drag that loses its release (window blur, pointer cancel or capture lost, a move with no button down) puts the island back or lands it, and the shell gives up a span whose button has been up for 3 s (companion://span-lost), so the window never stays spanned taking every click.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three changes, on top of v0.1.17.
The island goes to another screen again
Since v0.1.17 a drag of the pill kept the island on its own screen.
island::follow_span,screen_at). When it changes, the window spans that screen's work area instead (one screen at a time, never across two scales) and tells the page (companion://span).landPatch).pointercancel, lost pointer capture) puts the island back where it was. A move with no button down counts as the missed release. As a last resort, a window still spanned 3 s after the button came up goes back to the island's place and lets clicks through again (companion://span-lost).B.O.T.S's face by default
CLASSIC_ROBOT). A chosen face is kept.The deck's top-left character swaps agents
assistant.pick), saved for the next launch.DeckBar.svelteintodeck/DeckAgent.svelte.Repository
The repository moved to
Skollheim/bots: the release targets, the manifest's homepage, the README andCargo.tomlpoint there. The app identifier stayscom.beboite.bots, so settings are kept.Checks
bun run check: 0 errors, 0 warnings.vitest: 75 files, 544 tests.cargo test: 90 tests, 4 new onscreen_at(side by side with negative x, stacked, scales 1, 1.25 and 1.5, a gap between screens).