Repository navigation
feat(island): six places, moved by dragging the pill or from Settings - #49
Merged
Merged
Conversation
…nd by dragging its pill
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The island can live at six places: the top or the bottom of the screen, each at the left, the centre or the right. Top centre stays the default, and saved prefs without a place parse to it.
Moving it
lib/island/move.svelte.ts).island_span), the six places show as dashed targets, and the nearest one is filled.companion_dragwithdetach). Dropped near the island, wherever the island is, it docks back in (island::docksnow measures from the island's edge and side).At the bottom
At the left or right
Rust
island_frame,docks,followandisland_placetake the place (companion_window::AnchorandEdge, reused). Moving to another screen keeps the place.island_span, inacl.rsandbots.toml.Demo
place=top-left|top-center|top-right|bottom-left|bottom-center|bottom-rightin the pose (lib/island/pose.ts), with a fake taskbar for the bottom places. Fixed on the way:poseMusicrewrote the prefs and lost the demo's place.Checks
bun run check: 0 errors, 0 warnings.vitest: 72 files, 524 tests (place.test.tscovers the nearest-place snap and the prefs migration).cargo test: 86 tests.