♻️ Remove deprecated variables and methods across the package - #552
Open
lavigarg-simform wants to merge 1 commit into
Open
lavigarg-simform wants to merge 1 commit into
lavigarg-simform wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR finalizes a major-version cleanup by removing previously deprecated public APIs across the package (header parameters/properties, EventController.events, DateTimeExtensions.dateYMD, and an unused MaterialColor extension), aligning the codebase with the documented migration path and reducing ongoing maintenance surface.
Changes:
- Removed deprecated header parameters (
backgroundColor,iconColor) fromCalendarPageHeaderand its day/week/month subclasses, relying solely onHeaderStyle. - Removed deprecated
HeaderStylemembers and simplified header icon rendering to useIconDataConfigonly (hide icons by passingnullconfigs). - Removed deprecated helpers (
EventController.events,DateTimeExtensions.dateYMD) and the unusedMaterialColorExtension, and documented the breaking changes inCHANGELOG.md.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| lib/src/style/header_style.dart | Removes deprecated HeaderStyle fields and constructors params; keeps icon customization via IconDataConfig. |
| lib/src/extensions.dart | Removes deprecated dateYMD and unused MaterialColorExtension. |
| lib/src/event_controller.dart | Removes deprecated events getter and updates internal filtering to use allEvents. |
| lib/src/components/headers/calendar_page_header.dart | Removes deprecated header color parameters and renders icons solely via HeaderStyle / IconDataConfig. |
| lib/src/components/headers/day_page_header.dart | Drops deprecated iconColor/backgroundColor passthrough. |
| lib/src/components/headers/week_page_header.dart | Drops deprecated iconColor/backgroundColor passthrough. |
| lib/src/components/headers/month_page_header.dart | Drops deprecated iconColor/backgroundColor passthrough. |
| CHANGELOG.md | Adds an unreleased entry documenting the breaking removals and migration directions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lavigarg-simform
marked this pull request as ready for review
June 16, 2026 07:28
lavigarg-simform
requested review from
ParthBaraiya,
kavantrivedi and
vatsaltanna-simformsolutions
June 16, 2026 07:29
kavantrivedi
approved these changes
Jun 18, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes previously deprecated members from the flutter_calendar_view package that were marked for removal in the next major release. This is a breaking change that cleans up the codebase and improves the maintainability of the library.
Changes Made
1. CalendarPageHeader & Subclasses
Removed
backgroundColorandiconColorparameters from:CalendarPageHeaderDayPageHeaderMonthPageHeaderWeekPageHeaderMigration: Users should use
HeaderStyleand itsdecoration,leftIconConfig, andrightIconConfigproperties instead.ignore_for_file: deprecated_member_use_from_same_packagedirectives.2. HeaderStyle
Removed deprecated properties:
leftIconVisible- passnulltoleftIconConfigto hide the left iconrightIconVisible- passnulltorightIconConfigto hide the right iconleftIconPadding- useleftIconConfiginsteadrightIconPadding- userightIconConfiginsteadleftIcon- useleftIconConfiginsteadrightIcon- userightIconConfiginsteadSimplified icon rendering logic to use only
IconDataConfigproperties.3. EventController
eventsgetter - useallEventsinsteadallEventsinstead of the deprecated getter4. DateTimeExtensions
dateYMDgetter - usewithoutTimeinstead5. Other
MaterialColorExtensionand itsaccentgetter (unused in the package)Breaking Changes⚠️
✅ This is a breaking change requiring users to update their code.
All deprecated members have been completely removed from the codebase (not just marked as deprecated). Users must update their implementations to use the new APIs as shown in the migration guide above.
Checklist
Related issues