Skip to content

fix(cdp): record why a test email to a recipient without an address was skipped #626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Silthus wants to merge 2 commits into
base: master
Choose a base branch
from
+7 −3
Draft

fix(cdp): record why a test email to a recipient without an address was skipped #626

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d463280
fix(cdp): report a skipped test email send as skipped
Silthus Oct 27, 2026
11190d5
fix(cdp): keep the test endpoint's status for a skipped email
Silthus Oct 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions nodejs/src/cdp/services/messaging/email.service.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1140,6 +1140,10 @@ describe('EmailService', () => {
expect(result.error).toBeUndefined()
expect(result.metrics.map((m) => m.metric_name)).toEqual(['email_missing_recipient'])
expect(result.skipped).toBe(true)
expect(result.emailSendResult).toEqual({
status: 'skipped',
reason: expect.stringContaining('the recipient has no email address'),
})
expect(invocation.state.vmState?.stack).toEqual([{ success: false }])
})

Expand Down
6 changes: 3 additions & 3 deletions nodejs/src/cdp/services/messaging/email.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,10 +492,10 @@ export class EmailService {
// so record a skip with its own metric instead of an `email_failed`. Otherwise one project
// with bad data inflates the platform send failure rate.
if (!params.to?.email?.trim()) {
addLog(
'warn',
const skipReason =
'Skipping send: the recipient has no email address. Add a filter so only people with an email address reach this step.'
)
addLog('warn', skipReason)
result.emailSendResult = { status: 'skipped', reason: skipReason }
if (!isTest) {
result.metrics.push({
team_id: invocation.teamId,
Expand Down
Loading