Repository navigation
Conversation
PostHog/context-mill ships a send-transactional-email skill. Every consumer overlays context-mill on top of this repo's skills, so the build lint and the skills store must refuse that name here. The skills store list also gains instrument-metrics, which the build list already reserved. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved here from #118927, closed on 2026-10-25 so this fork stack is the only copy. It opens upstream again after review.
Problem
Silthus/context-mill#3 adds a
send-transactional-emailskill. Every consumer overlays context-mill on top of this repo's skills, so a posthog skill or a store skill with that name would be silently overwritten or would shadow it. The skills store list had also drifted: it never reservedinstrument-metrics, which the build list already holds.Tracking: Silthus/posthog#476.
Note
🔵 Merge risk: low · two-way door (merge-risk rubric)
send-transactional-emailandinstrument-metricsas store skill names, andhogli lint:skillsrefuses the first underproducts/*/skills/. No skill in the tree uses either name.Changes
hogli lint:skillsfails on a product skill namedsend-transactional-email(reserved_names.py).send-transactional-emailandinstrument-metrics(bundled_skills.py).How did you test this code?
A scratch product skill named
send-transactional-email, asked of both guards, before and after:upstream/masterhogli lint:skillsOK: 164 product skill(s) ... passedERROR: 'send-transactional-email' is owned by PostHog/context-mill ...'send-transactional-email' in bundled_skill_names()FalseTrue'instrument-metrics' in bundled_skill_names()FalseTrueproducts/posthog_ai/scripts/test/test_build_skills.pyandproducts/skills/backend/test_bundled_skills.pypass. The pre-pushhogli ci:preflight --strictpassed with 0 failures.Test rationale: no new test. A membership assertion would restate the constant. The guards themselves are covered by
test_lint_all_catches_reserved_name_in_frontmatterandtest_bundled_skill_names_holds_the_tree_and_the_omnibus_names. A test that the two lists match would catch the next drift, but it would import across the isolatedproducts.skillsboundary.Release status
Docs update
The writing-skills handbook page and skill list the new name.
🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Agent: Claude Code, Claude Opus 5.5
/writing-skills,/writing-pr-descriptions.🤖 Generated with Claude Code