Repository navigation
Conversation
Silthus
force-pushed
the
workflows-sandbox/first-delivery
branch
from
October 12, 2026 23:16
c66d8d8 to
4eab350
Compare
Silthus
force-pushed
the
workflows-sandbox/first-delivery
branch
from
October 12, 2026 23:53
4eab350 to
16c34fb
Compare
Silthus
force-pushed
the
workflows-sandbox/first-delivery
branch
2 times, most recently
from
October 19, 2026 10:58
c435776 to
d28e139
Compare
This was referenced Oct 19, 2026
Silthus
force-pushed
the
workflows-sandbox/first-delivery
branch
from
October 19, 2026 13:11
d28e139 to
66edb94
Compare
Silthus
force-pushed
the
workflows-sandbox/first-delivery
branch
from
October 19, 2026 13:36
66edb94 to
f90a613
Compare
Silthus
force-pushed
the
workflows-sandbox/first-delivery
branch
from
October 23, 2026 16:26
f90a613 to
370462b
Compare
Silthus
force-pushed
the
workflows-sandbox/first-delivery
branch
from
October 24, 2026 13:12
370462b to
dafe929
Compare
Owner
Author
|
Note 🤖 Claude Opus 5.5 responding on behalf of Michael Decision lines for this PR. The Decisions table in the description links each row here.
|
19 tasks
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Silthus
force-pushed
the
workflows-sandbox/first-delivery
branch
from
October 26, 2026 05:01
dafe929 to
637101b
Compare
This was referenced Oct 27, 2026
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Sandbox email must not earn a project's own sending tier, and accepted sends need a distinct delivery signal.
Supersedes PostHog#111904 (left open as the original draft).
Stack: layer 10 of 12, stacked on #453. Next: #455.
This fork PR moves to an upstream PostHog/posthog PR after review.
Warning
🟡 Merge risk: medium · one-way door (merge-risk rubric)
Changes
Before:
flowchart LR A[All sends] --> B[Tier history] C[SES delivery] --> D[Email delivery metrics] classDef phYellow fill:#f9bd2b,stroke:#f9bd2b,color:#000 classDef phGray fill:#e5e7eb,stroke:#c7ccd1,color:#000 class A,C phYellow class B,D phGrayAfter:
flowchart LR A[Own sends] --> B[Tier history] C[Signed sandbox delivery] --> D[Email delivery metrics] C --> E[Sandbox delivered event] classDef phYellow fill:#f9bd2b,stroke:#f9bd2b,color:#000 classDef phGray fill:#e5e7eb,stroke:#c7ccd1,color:#000 class A,C phYellow class B,D,E phGrayHow did you test this code?
Current evidence, 2026-10-24, head
dafe929b5d8.Owed proofs:
8ac8853cc82, which contains this layer. The stack's cdp-api sent through the workflow test-run endpoint to a local SES fake that records each request. 9 of 9 cases pass. 12 of 13 recorded cases match the run atfa33d78fb36. Case 2c (an unverified member on To) now shows the verify-your-email guidance with reasonrecipient_unverified, and makes no SES request. No case covers SES delivery notifications or tier history, which need real SES feedback; the webhook and tier tests cover them.Changes in this layer since the 2026-10-19 heads (restacked onto fork master
448d802: no conflict in this layer):email_sandbox_sent, as the tier sweep does (test_sending_allowance_leaves_out_sandbox_sends).test_sending_allowance_leaves_out_sandbox_sends, mutation checked red then green).recipient_unverifiedreason from feat(workflows): restrict sandbox email to verified org members #434. Type only; delivery history is unchanged.Local gate at the stack tip
8ac8853cc82, shared by every layertscand frontendtsgo: clean.Test seams: SES webhook attribution, ClickHouse-backed tier recomputation and the sending allowance API.
Test rationale: Existing signed-delivery cases distinguish sandbox from own sends and count recipient copies. Tier-history cases cover per-day subtraction, retained feedback and promotion/decay.
Gaps: real AWS SES delivery and the AWS-side tenant pause (every proof uses a local SES fake or an unreachable SES), clustered Valkey, the production data shape (prod-shape gap until production read access on 2026-11-02), and fork CI, which fails during setup: path selection fails without a GitHub App client ID, and the Security aggregate rejects its fork-skipped path-filter job. Application CI is a verification gap.
Earlier evidence (superseded heads)
Round 3 heads, 2026-10-23. This layer's head:
370462bc02a. Stack tipfa33d78fb36.fa33d78fb36, which contains this layer. The stack's cdp-api sent through the workflow test-run endpoint to a local SES fake that records each request. 9 of 9 cases pass, identical to the earlier run. No case covers SES delivery notifications or tier history, which need real SES feedback; the webhook and tier tests cover them.fa33d78fb36: Python 3007 passed; Node CDP 42 suites, 1157 passed; email service suites at the final heads of feat(workflows): restrict sandbox email to verified org members #434, feat(workflows): cap sandbox sends and refund ses throttles #441, feat(workflows): test templates with the sandbox sender #451 and feat(workflows): honor shared sandbox tenant pauses #453 passed; frontend Jest 17 changed suites, 290 passed; mypy, Nodetscand frontendtsgoclean; ruff, oxfmt, oxlint, prettier and eslint clean on the files changed since round 2. Final read 1 found nothing.Whole-stack QA swarm, 2026-10-19. Reviewed tip
cfee7e148ae. This layer's head:f90a613d5b6.b9bd346ed0e(this stack's cdp-api against a local SES fake, workflow test-run endpoint): a sandbox send to a verified member went out from the fixed identity through the sandbox tenant and configuration set. The step's From name, From address and Reply-To were ignored with a log line. A non-member on CC and an unverified member were blocked with the clear message. A paused tenant state skipped sandbox sends while own-sender sends continued.1a0fe3663c2; later fixes touch no Node code): Node CDP messaging, members and rate limiter suites (includingemail-tracking.service.test.ts, which now runs), the cdp-api suite, the Python sandbox, tenant, tier, reputation and validation suites, the frontend Jest suites of this stack, ruff, and the strict pre-push preflight: pass.Rebased onto master
734468db6f9(2026-10-19), headd28e139a268.test_email_sending_tier.pypasses at the tip (below).email-tracking.service.test.tsdid not run then. It runs now; see the QA swarm block above. Fork CI still fails during setup, as noted below. Real AWS delivery and clustered Valkey remain unchecked.Checks at the stack tip
Stack tip
b9bd346ed0e(#456), shared by every layer:tsgo: no errors. Nodetsgo: no errors in CDP. The 23 errors it reports are all in session replay files that need the unbuilt Rust@posthog/replay-anonymizermodule.product:lint(workflows, cdp), IDOR coverage,hogli build:openapi(no diff), and the strict pre-push preflight: pass.Observed targeted verification after QA fixes
Observed combined-stack gate
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Release status
Docs update
Updates the existing email sending tiers document with sandbox subtraction and delivery capture configuration.
🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Decisions
Involvement: restack onto fork master
448d802on 2026-10-23; round 1 with GPT-6.1 Sol lanes plus Claude Opus 5.5 fresh eyes for group G4; round 2 on the fix diff; final read 1 by GPT-6.1 Sol per group, with no findings; proofs captured; final read 2 by GPT-6.1 Sol on the round 4 decisions, with no findings; the round 4 live run and a UI walk of the two changed surfaces. Before that: the 2026-10-19 whole-stack QA swarm and the modernize rebase (see Earlier evidence). No review bots run on the fork.Agent: Codex with GPT-6.1 Sol (gpt-6.1-sol) built the original layers, orchestrated by Claude Code with Claude Opus 5.5 (claude-opus-5-5). Restack, review fixes and this description refresh: Claude Opus 5.5 (claude-opus-5-5). Review: GPT-6.1 Sol (gpt-6.1-sol). Fresh eyes: Claude Opus 5.5 (claude-opus-5-5).
Skills:
tdd,pr,writing-pr-descriptions,stacking-prs,merge-risk,qa-swarm,running-ci-preflight, andwriting-voice. The description refresh usedpr-description,writing-pr-descriptions,writing-voiceandmerge-risk.The shared sender instance supplies webhook configuration. Public source and invented fixtures only.
🤖 Generated with Claude Code