Repository navigation
Conversation
Silthus
force-pushed
the
workflows-sandbox/tenant-state-schema
branch
from
October 12, 2026 16:06
12ed3ba to
03cfde8
Compare
Silthus
force-pushed
the
workflows-sandbox/tenant-state-schema
branch
2 times, most recently
from
October 12, 2026 23:52
b278a08 to
db364b6
Compare
Silthus
force-pushed
the
workflows-sandbox/tenant-state-schema
branch
2 times, most recently
from
October 19, 2026 10:58
8cc626f to
ae4332b
Compare
This was referenced Oct 19, 2026
Silthus
force-pushed
the
workflows-sandbox/tenant-state-schema
branch
from
October 19, 2026 13:11
ae4332b to
61ac274
Compare
Silthus
force-pushed
the
workflows-sandbox/tenant-state-schema
branch
from
October 19, 2026 13:36
61ac274 to
2220fc4
Compare
Silthus
force-pushed
the
workflows-sandbox/tenant-state-schema
branch
from
October 23, 2026 16:26
2220fc4 to
27a38a9
Compare
Silthus
force-pushed
the
workflows-sandbox/tenant-state-schema
branch
from
October 24, 2026 13:12
27a38a9 to
822e7d0
Compare
Owner
Author
|
Note 🤖 Claude Opus 5.5 responding on behalf of Michael Decision lines for this PR. The Decisions table in the description links each row here.
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Silthus
force-pushed
the
workflows-sandbox/tenant-state-schema
branch
from
October 26, 2026 05:00
822e7d0 to
74e68e0
Compare
Owner
Author
|
Replaced by the re-sliced fork stack: #607. Tracked in Silthus/personal#71. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The shared sandbox sender needs a durable SES tenant state before workers can honor provider pauses.
Supersedes PostHog#111820 (left open as the original draft), together with the following pause behavior layer.
Stack: layer 8 of 12, stacked on #451. Next: #453.
This fork PR moves to an upstream PostHog/posthog PR after review.
Warning
🟡 Merge risk: medium · two-way door (merge-risk rubric)
Changes
Adds the shared SES tenant state model and migration
0037_sandbox_sender_tenant_stateafter master's 0036. The table holds the tenant name, its SES sending status and the last sync time. This layer changes no sending behavior.How did you test this code?
Current evidence, 2026-10-24, head
822e7d0e022.Owed proofs:
8ac8853cc82, which contains this layer. The stack's cdp-api sent through the workflow test-run endpoint to a local SES fake that records each request. 9 of 9 cases pass. 12 of 13 recorded cases match the run atfa33d78fb36. Case 2c (an unverified member on To) now shows the verify-your-email guidance with reasonrecipient_unverified, and makes no SES request. For this layer: case 6, under cross-version below.fa33d78fb36and rerun at8ac8853cc82with the same result. A tip worker on a database without migration 0037 skips sandbox sends (it fails closed, with no SES request), while own-sender sends go out.Changes in this layer since the 2026-10-19 heads (restacked onto fork master
448d802: the migration is renumbered from 0035 to 0037 and depends on master's 0036):reputation_impactcolumn is dropped; nothing read it.Local gate at the stack tip
8ac8853cc82, shared by every layertscand frontendtsgo: clean.Test seams: migration dependency invariant, generated SQL and model drift check.
Test rationale: The existing database-placement invariant covers the additive model. SQL application and drift checks exercise migration safety; no trivial model-field tests are added.
Gaps: real AWS SES delivery and the AWS-side tenant pause (every proof uses a local SES fake or an unreachable SES), clustered Valkey, the production data shape (prod-shape gap until production read access on 2026-11-02), and fork CI, which fails during setup: path selection fails without a GitHub App client ID, and the Security aggregate rejects its fork-skipped path-filter job. Application CI is a verification gap.
Earlier evidence (superseded heads)
Round 3 heads, 2026-10-23. This layer's head:
27a38a9c8a2. Stack tipfa33d78fb36.fa33d78fb36, which contains this layer. The stack's cdp-api sent through the workflow test-run endpoint to a local SES fake that records each request. 9 of 9 cases pass, identical to the earlier run. For this layer: case 6, under cross-version below.fa33d78fb36: Python 3007 passed; Node CDP 42 suites, 1157 passed; email service suites at the final heads of feat(workflows): restrict sandbox email to verified org members #434, feat(workflows): cap sandbox sends and refund ses throttles #441, feat(workflows): test templates with the sandbox sender #451 and feat(workflows): honor shared sandbox tenant pauses #453 passed; frontend Jest 17 changed suites, 290 passed; mypy, Nodetscand frontendtsgoclean; ruff, oxfmt, oxlint, prettier and eslint clean on the files changed since round 2. Final read 1 found nothing.Whole-stack QA swarm, 2026-10-19. Reviewed tip
cfee7e148ae. This layer's head:2220fc4f7d9.b9bd346ed0e(this stack's cdp-api against a local SES fake, workflow test-run endpoint): a sandbox send to a verified member went out from the fixed identity through the sandbox tenant and configuration set. The step's From name, From address and Reply-To were ignored with a log line. A non-member on CC and an unverified member were blocked with the clear message. A paused tenant state skipped sandbox sends while own-sender sends continued.1a0fe3663c2; later fixes touch no Node code): Node CDP messaging, members and rate limiter suites (includingemail-tracking.service.test.ts, which now runs), the cdp-api suite, the Python sandbox, tenant, tier, reputation and validation suites, the frontend Jest suites of this stack, ruff, and the strict pre-push preflight: pass.Rebased onto master
734468db6f9(2026-10-19), headae4332b07a5.0033_workflowideaand0034_teamworkflowsconfig_replay_vision_scan_limits.0035_sandbox_sender_tenant_stateon top of0034, andmax_migration.txtfollows.sqlmigrateemits oneCREATE TABLEand itstenant_namepattern index.makemigrations --checkreports no changes. The IDOR coverage check passes.email-tracking.service.test.tsdid not run then. It runs now; see the QA swarm block above. Fork CI still fails during setup, as noted below. Real AWS delivery and clustered Valkey remain unchecked.Checks at the stack tip
Stack tip
b9bd346ed0e(#456), shared by every layer:tsgo: no errors. Nodetsgo: no errors in CDP. The 23 errors it reports are all in session replay files that need the unbuilt Rust@posthog/replay-anonymizermodule.product:lint(workflows, cdp), IDOR coverage,hogli build:openapi(no diff), and the strict pre-push preflight: pass.Observed targeted verification after QA fixes
Observed combined-stack gate
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Release status
Docs update
The following behavior layer updates the existing email sending tiers document.
🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Decisions
reputation_impactcolumn (G4-3)Involvement: restack onto fork master
448d802on 2026-10-23; round 1 with GPT-6.1 Sol lanes plus Claude Opus 5.5 fresh eyes for group G4; round 2 on the fix diff; final read 1 by GPT-6.1 Sol per group, with no findings; proofs captured; final read 2 by GPT-6.1 Sol on the round 4 decisions, with no findings; the round 4 live run and a UI walk of the two changed surfaces. Before that: the 2026-10-19 whole-stack QA swarm and the modernize rebase (see Earlier evidence). No review bots run on the fork.Agent: Codex with GPT-6.1 Sol (gpt-6.1-sol) built the original layers, orchestrated by Claude Code with Claude Opus 5.5 (claude-opus-5-5). Restack, review fixes and this description refresh: Claude Opus 5.5 (claude-opus-5-5). Review: GPT-6.1 Sol (gpt-6.1-sol). Fresh eyes: Claude Opus 5.5 (claude-opus-5-5).
Skills:
tdd,pr,stacking-prs,writing-pr-descriptions,merge-risk,qa-swarm,django-migrations,running-ci-preflight, andwriting-voice. The description refresh usedpr-description,writing-pr-descriptions,writing-voiceandmerge-risk.The schema prerequisite forms a separate layer so deployment order and instance-global scoping can be reviewed independently. No private session material is included.
🤖 Generated with Claude Code