Bring the agent sender-verification tools to PostHog/posthog #466

Activity

1. Silthus

   added

   wayfinder:task

   on Oct 14, 2026
2. Silthus

   added a parent issue on Oct 14, 2026

   • Map: send code-managed email templates with one PostHog call #461
3. Silthus

   self-assigned this

   on Oct 14, 2026
4. Silthus commented on Oct 14, 2026

   

   Silthus

   on Oct 14, 2026

   OwnerAuthor

   More actions

   Decisions (Michael, 2026-10-14):

   • The conductor brings feat(workflows): let agents set up an email sending domain via mcp #343, fix(workflows): keep one mail from label per email sending domain #345, feat(workflows): expose read-only email sending readiness #351 and fix(integrations): scope email sender verification and updates #352 upstream itself; Michael tells the person who planned the migration that it is covered.
   • The spec does not wait for this ticket. The spec assumes the tools land; only the skill's implementation ticket will be blocked by this one.
5. Silthus commented on Oct 14, 2026

   

   Silthus

   on Oct 14, 2026

   OwnerAuthor

   More actions

   Runtime: Claude Code background Agent
   Worker: task-466-sender-tools-upstream
   Cast: Opus 5.5, high. Wall-time cap: 150 minutes.
6. Silthus commented on Oct 14, 2026

   

   Silthus

   on Oct 14, 2026

   OwnerAuthor

   More actions

   Claimed by conductor dispatch. Runtime: Claude Code background Agent, worker task-466-sender-tools-upstream, Opus 5.5 high.
7. Silthus

   marked this as blocking on Oct 14, 2026

   • Agent skill: verify a sender, upload the template from the repo, send by key #476
8. Silthus commented on Oct 14, 2026

   

   Silthus

   on Oct 14, 2026

   OwnerAuthor

   More actions

   Resolution

   The sender verification tools are open as reviewed draft PRs on PostHog/posthog, rebased on master eebb24a87c0.

   Upstream PR	Reviewed head	Replaces	Depends on
   #116863 five MCP sender tools, scopes, schemas, skill, evals	e057075a5f9	Silthus#343 + Silthus#352	master
   #116864 one MAIL FROM label per domain	4dbd4d533bd	Silthus#345	PostHog#116863
   #116865 readiness tools, config.verified in integrations-list	9d7065d09c5	Silthus#351	master

   All three gate on workflows-email-domain-agent-setup (default off). Branches are new (upstream/* on the fork); the original fork branches and PRs are untouched.

   Calls made

   • fix(integrations): scope email sender verification and updates #352 folded into feat(workflows): let agents set up an email sending domain via mcp PostHog/posthog#116863. It only adds tests and guide text for feat(workflows): let agents set up an email sending domain via mcp #343's routes and cannot land alone.
   • feat(workflows): expose read-only email sending readiness over mcp PostHog/posthog#116865 is not stacked. feat(workflows): expose read-only email sending readiness #351's own commit applies to master without the docs stack it sat on in the fork.
   • Rebase conflicts: the moved sender serializer keeps master's reply_to (feat(workflows): add a default reply-to address to email senders PostHog/posthog#115898), so the update tool also edits the reply-to address; sender edits now reload workers on commit; the eval SES simulation answers master's new feedback-forwarding call; fix(workflows): keep one mail from label per email sending domain #345's duplicate flag constant and helper became one helper in posthog/models/integration/email.py.
   • Label rule stays per acting user (raised by both review models): a user-targeted rollout mixes old and new MAIL FROM behavior on one domain. Kept, because the MCP server shows the tools per user and the API gate uses the same check. The PR body says to roll the flag out by organization. Alternative: evaluate the label rule per project only.

   Gate and tests

   • Isolated test DB (--nomigrations): posthog/api/test/test_integration.py, serializer, Domain Connect, email model, eval and products/workflows/backend tests green on each head.
   • MCP generator, filtering, apply-url, readiness and schema snapshot suites green.
   • hogli build:openapi + hogli build:schema-mcp clean, repo-wide mypy clean, hogli ci:preflight --strict passed (also in the pre-push hook).
   • Not run: the eval suite (needs LLM keys), a live MCP session, real SES, upstream CI beyond the draft subset (fork runs wait for maintainer approval). MCP typecheck fails in this checkout only on the unbuilt @posthog/quill package, in untouched files.

   Review

   Two rounds, GPT-6.1 Sol (Codex, high) and a fresh Claude Opus 5.5. merge-risk: PostHog#116863 medium, PostHog#116864 low, PostHog#116865 low (one-way door: tool names).

   • Fixed: stale tool-inputs.json without reply_to; reply_to missing from the OAuth guide and skill; duplicate test flag entry; mypy error in a new test; apply-url tool now hides redirect_uri; default-sender memo cleared before commit under the domain lock (now cleared again on commit, queued before the worker reload); five generic fork tests removed from feat(workflows): expose read-only email sending readiness over mcp PostHog/posthog#116865.
   • Rejected: a test for the second memo clear (the stale read needs a second connection); "defaults to feedback" help text (accurate with the flag off; the create tool tells agents to pass the domain's label).
   • CodeRabbit: skipped, retired on the repo.

   Follow-ups

   • integrations-email-partial-update needs the sender's name, which no read tool returns. Making it optional changes the API contract.
   • Master's per-process workflows config memo can let a config PATCH on another worker write back a stale default sender. Predates these PRs.
   • Assignee could not be set on the upstream PRs (permission error); Michael is the DRI per the PR bodies.
9. Silthus

   closed this as completedon Oct 14, 2026