feat: enable building as py3-none wheel - #6
Merged
Merged
Conversation
donn
commented
Aug 28, 2026
Collaborator
- also build prunefl as manylinux wheels installable by PIP
- drop version that has never been updated for CalVer
- drop Nix derivation in favor of a shell
donn
force-pushed
the
donn/py3_none_wheel
branch
from
August 28, 2026 07:38
f9d678c to
abb354c
Compare
Greptile SummaryThe PR replaces native tarball releases with a custom PEP 517 backend that builds platform wheels, adopts date-based versions, and replaces the packaged Nix derivation with a development shell.
Confidence Score: 3/5The PR is not safe to merge until the wheel backend parses successfully and passes the selected package version into the binary build. Every packaging operation imports a backend containing an invalid f-string, and after that is corrected the current CMake invocation still embeds a date rather than the collision-resolved wheel version. Files Needing Attention: wheel_build/init.py, CMakeLists.txt
|
| Filename | Overview |
|---|---|
| wheel_build/init.py | Adds the custom packaging backend, but an invalid f-string prevents import and version propagation would desynchronize wheel and binary versions. |
| CMakeLists.txt | Replaces VERSION-file generation with a pre-build date/version generator whose value must be supplied correctly by packaging callers. |
| .github/workflows/ci.yml | Consolidates testing, wheel builds, releases, and server uploads, but its wheel path currently reaches the broken backend. |
| pyproject.toml | Selects the new in-tree PEP 517 backend and declares its build dependencies. |
| misc/make_version_cc.py | Generates the C++ version symbol from an argument or falls back to the current date. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart LR
Event[Push, pull request, or manual run] --> Tests[C++ build and tests]
Event --> Version[Choose unused CalVer]
Tests --> Wheels[cibuildwheel]
Version --> Wheels
Wheels --> Backend[PEP 517 wheel_build backend]
Backend --> CMake[Configure and build prunefl]
CMake --> Package[Platform wheel]
Package --> Artifacts[Upload artifacts]
Artifacts --> Release[GitHub release on non-PR runs]
Release --> Server[Silimate download server]
Reviews (1): Last reviewed commit: "feat: enable building as py3-none wheel" | Re-trigger Greptile
donn
force-pushed
the
donn/py3_none_wheel
branch
5 times, most recently
from
August 28, 2026 11:55
fb8d775 to
1e3cf43
Compare
akashlevy
requested changes
Aug 28, 2026
donn
force-pushed
the
donn/py3_none_wheel
branch
4 times, most recently
from
August 31, 2026 08:01
79851ae to
98dc5e3
Compare
- also build prunefl as manylinux wheels installable by PIP - drop version that has never been updated for CalVer - drop Nix derivation in favor of a shell
donn
force-pushed
the
donn/py3_none_wheel
branch
from
August 31, 2026 08:01
98dc5e3 to
45edde5
Compare
akashlevy
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.