feat: enable building as py3-none wheel - #1
Merged
Conversation
donn
force-pushed
the
donn/py3_none_wheel
branch
6 times, most recently
from
September 4, 2026 12:06
1968ad9 to
d61bcb6
Compare
donn
marked this pull request as ready for review
September 4, 2026 12:10
- update release CI to build wheels instead of tarballs - adapt wheel_build from silisizer - add brewfile for dependencies - update codebase to better handle relocation and allow all tests to pass with wheel installation - fix missing header include in driver/main.c
donn
force-pushed
the
donn/py3_none_wheel
branch
from
September 4, 2026 12:13
d61bcb6 to
e6fda45
Compare
Greptile SummaryThis PR introduces relocatable, Python-version-independent binary wheels for Icarus Verilog and updates release and test automation accordingly.
Confidence Score: 4/5The implementation appears functionally safe, but the repository’s explicit documentation requirement for The only remaining issue is that the complex sdist construction and filtering function lacks the purpose documentation required by the repository. All six previous findings were manually resolved without explanatory replies and therefore are not outstanding. Files Needing Attention: wheel_build/init.py
|
| Filename | Overview |
|---|---|
| wheel_build/init.py | Implements the custom wheel backend, metadata generation, build bootstrap, native compilation, and wheel assembly; build_sdist lacks the purpose documentation required by repository rules. |
| .github/workflows/release.yml | Replaces tarball releases with a tested cibuildwheel matrix and gated release/upload jobs. |
| driver/driver_portable.cc | Resolves runtime include and library paths relative to the relocated executable prefix. |
| driver/Makefile.in | Adds the portable C++ driver object and links the driver with the configured C++ compiler. |
| .github/workflows/test.yml | Centralizes macOS dependencies in the Brewfile and regenerates Autoconf inputs before building. |
| install-sh | Updates the fallback installation helper to a current GNU Automake implementation compatible with existing installation rules. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart LR
A[Push or pull request] --> B[Determine unused wheel version]
B --> C{Build matrix}
C --> D[Linux manylinux build]
C --> E[macOS arm64 build]
D --> F[Repair and smoke-test wheel]
E --> F
F --> G[Install wheel and run full tests]
G --> H[Upload wheel artifacts]
H --> I{Pull request?}
I -->|Yes| J[Finish validation]
I -->|No| K[Create GitHub prerelease]
K --> L[Upload to download server]
Reviews (4): Last reviewed commit: "ci: update macos upstream test" | Re-trigger Greptile
also remove configure script, it's broken and all CI builds use autoconf first anyway
donn
force-pushed
the
donn/py3_none_wheel
branch
from
September 4, 2026 12:40
ab692c7 to
66e197b
Compare
Author
|
@greptile-apps re-review |
donn
force-pushed
the
donn/py3_none_wheel
branch
from
September 4, 2026 12:52
1ce6c4d to
9c3ede1
Compare
donn
marked this pull request as draft
September 4, 2026 13:14
donn
force-pushed
the
donn/py3_none_wheel
branch
from
September 4, 2026 14:49
9c3ede1 to
9fadfc2
Compare
donn
force-pushed
the
donn/py3_none_wheel
branch
from
September 4, 2026 14:56
9fadfc2 to
de893e5
Compare
donn
marked this pull request as ready for review
September 4, 2026 15:10
donn
force-pushed
the
donn/py3_none_wheel
branch
from
September 4, 2026 16:17
746407f to
5b8b75f
Compare
akashlevy
approved these changes
Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO