Revert "Return an empty list from get_property on an empty collection" - #81
Merged
Conversation
Greptile SummaryReverts the empty-collection behavior previously added to
Confidence Score: 5/5The PR appears safe to merge as the restored behavior is the explicit purpose of this revert and no separate actionable defect was identified. The implementation, help text, and regression suite are consistently restored to the pre-change behavior described by the PR.
|
| Filename | Overview |
|---|---|
| tcl/Property.tcl | Restores the prior null-object error and removes documentation promising empty-list results for empty collections. |
| test/get_property_empty.tcl | Removes the reverted behavior’s dedicated Tcl regression test. |
| test/regression_vars.tcl | Removes the deleted test from the public regression suite. |
Reviews (1): Last reviewed commit: "Revert "Return an empty list from get_pr..." | Re-trigger Greptile
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #80