Skip to content

Revert "Return an empty list from get_property on an empty collection" - #81

Merged
akashlevy merged 1 commit into
mainfrom
revert-80-get-property-empty
Sep 2, 2026
Merged

Revert "Return an empty list from get_property on an empty collection"#81
akashlevy merged 1 commit into
mainfrom
revert-80-get-property-empty

Conversation

@akashlevy

Copy link
Copy Markdown

Reverts #80

@akashlevy
akashlevy merged commit 87da01f into main Sep 2, 2026
7 checks passed
@greptile-apps

greptile-apps Bot commented Sep 2, 2026

Copy link
Copy Markdown

Greptile Summary

Reverts the empty-collection behavior previously added to get_property, restoring the null-object error and removing its dedicated regression coverage.

  • Restores Error 2200 for empty get_property object arguments.
  • Removes the empty-collection test fixture and regression registration.

Confidence Score: 5/5

The PR appears safe to merge as the restored behavior is the explicit purpose of this revert and no separate actionable defect was identified.

The implementation, help text, and regression suite are consistently restored to the pre-change behavior described by the PR.

Important Files Changed

Filename Overview
tcl/Property.tcl Restores the prior null-object error and removes documentation promising empty-list results for empty collections.
test/get_property_empty.tcl Removes the reverted behavior’s dedicated Tcl regression test.
test/regression_vars.tcl Removes the deleted test from the public regression suite.

Reviews (1): Last reviewed commit: "Revert "Return an empty list from get_pr..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant