Skip to content

Dump max_logic_levels as null if it isn't set (not to 0) - #79

Merged
gigeresk merged 1 commit into
mainfrom
max-lol-sentinel-value
Aug 29, 2026
Merged

Dump max_logic_levels as null if it isn't set (not to 0)#79
gigeresk merged 1 commit into
mainfrom
max-lol-sentinel-value

Conversation

@gigeresk

@gigeresk gigeresk commented Aug 29, 2026

Copy link
Copy Markdown

No description provided.

@greptile-apps

greptile-apps Bot commented Aug 29, 2026

Copy link
Copy Markdown

Greptile Summary

The PR changes target_ppa_json to serialize an unset max_logic_levels constraint as JSON null rather than 0, while avoiding mutation of the global variable.

  • Uses a local serialization value when the global constraint exists.
  • Emits the JSON literal null when the constraint is absent.
  • Removes incidental trailing whitespace.

Confidence Score: 5/5

The PR appears safe to merge with no actionable defects identified.

The changed procedure preserves configured numeric values, emits valid JSON null for the intended unset state, and no repository or related-repository code depends on the removed global-initialization side effect.

Important Files Changed

Filename Overview
tcl/Extras.tcl Correctly distinguishes an unset logic-level constraint from an explicit numeric value without introducing a concrete contract or runtime failure.

Reviews (1): Last reviewed commit: "Dump max_logic_levels as null if it isn'..." | Re-trigger Greptile

@gigeresk
gigeresk merged commit fadbcd8 into main Aug 29, 2026
9 checks passed
@gigeresk
gigeresk deleted the max-lol-sentinel-value branch August 29, 2026 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants