Add set_max_lol - #77
Closed
gigeresk wants to merge 4 commits into
Closed
Conversation
Greptile SummaryThe PR adds
Confidence Score: 5/5The PR appears safe to merge because the previously reported SDC round-trip and database compatibility failures have been corrected. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| sdc/Sdc.cc | Initializes max_lol_ to the -1 sentinel and provides straightforward storage accessors, resolving the previously reported unset-state ambiguity. |
| sdc/WriteSdc.cc | Emits set_max_lol for every configured nonnegative value, preserving explicit zero while omitting the unset sentinel. |
| stadb/DbFormat.hh | Advances the snapshot format version so older and newer binaries reject incompatible SDC encodings at the format boundary. |
| stadb/DbSdc.cc | Symmetrically writes and restores max_lol using the signed integer codec, which preserves the -1 sentinel. |
| sdc/Sdc.tcl | Adds the public command with integer validation that accepts zero as intended. |
Reviews (3): Last reviewed commit: "-1 is sentinel value" | Re-trigger Greptile
Author
Author
|
Why do we need this in the STA side? Logic levels is computed on Preqorsor side? |
akashlevy
requested changes
Aug 27, 2026
akashlevy
left a comment
There was a problem hiding this comment.
Explain why this should be here and not in preqorsor?
|
I think it already is in preqorsor in fact. Please double check this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
set_max_lol <int>function.Sentinel value is -1, so we allow
set_max_lol 0.