#94: reject remove-failed requests for nodes outside the network

[Peter Balogh (silabs-peterb)]

Issue

• Trying to remove non-existent "failed" LR node sends unwanted Classic and Mesh NOP #94
• JIRA: ZWAVE_SDK-1970 ZWAVE_SDK-2021

Closes: #94

Change

Summary

Prevent Remove Failed operations from being started for nodes that are no longer part of the Z-Wave network.

This avoids:

• Sending an unintended Classic/Mesh NOP after retrying Remove Failed for an already-removed LR node.
• Repeatedly reporting successful removal for an already-removed classic node.
• Publishing conflicting failure reports for an already-removed LR node.

Changes

• Check the cached network node list before starting a Remove Failed operation.
• Return SL_STATUS_NOT_FOUND when the requested NodeID is not present.
• Report the failure as operation_failed through the MQTT API.
• Document the new return value.

Checklist

• Pull request template has been filled out correctly
• ./ci/scripts/clang-tidy.sh check has been run locally (see CONTRIBUTING.md)
• Documentation has been updated if necessary
• A Contribution License Agreement has been established between Silicon Labs (@SiliconLabs) and author's company (matching email domain)

[cursor]

PR Summary

Low Risk
Adds an early membership check and clearer MQTT failure reporting; it does not change the remove-failed path for nodes that remain on the network.

Overview
Remove Failed requests for a NodeID that is not in the cached network list are now rejected before any Z-Wave remove-failed flow starts.

zwave_network_management_remove_failed checks nms.cached_node_list and returns SL_STATUS_NOT_FOUND when the node is absent. The MQTT handler maps that status to reason operation_failed (REMOVE_FAILED_STATUS_OPERATION_FAILED) instead of not_ready, while other start failures still use not_ready. The public API docs now describe the SL_STATUS_NOT_FOUND case.

^{Reviewed by Cursor Bugbot for commit 921aa5f. Configure here.}

[siliconlabsdevops-svc-devops]

CTT Jenkins job: $zpc_ctt_jenkins_url/job/zw-ctt-automation-multibranch/job/main/3715/

[siliconlabsdevops-svc-devops]

CTT Jenkins job: $zpc_ctt_jenkins_url/job/zw-ctt-automation-multibranch/job/main/3717/

[Peter Balogh (silabs-peterb)]

CTT Jenkins job: $zpc_ctt_jenkins_url/job/zw-ctt-automation-multibranch/job/main/3715/

No regression was introduced