#88: Fix misleading NLS status report - #90
Merged
Márk Mihalik | SiliconLabs (silabs-MarkM) merged 1 commit intoSep 16, 2026
Conversation
Márk Mihalik | SiliconLabs (silabs-MarkM)
added
Bug
Aydogan Ersoz (silabs-aydogane)
requested changes
Sep 15, 2026
Márk Mihalik | SiliconLabs (silabs-MarkM)
force-pushed
the
88-nls-misleadin-report-fix
branch
from
September 15, 2026 08:38
8632db3 to
c2d69ae
Compare
Signed-off-by: Márk Mihalik <Mark.Mihalik@silabs.com>
Márk Mihalik | SiliconLabs (silabs-MarkM)
force-pushed
the
88-nls-misleadin-report-fix
branch
from
September 15, 2026 08:38
c2d69ae to
48b234d
Compare
Márk Mihalik | SiliconLabs (silabs-MarkM)
added
the
CTT Requested (Full Set)
siliconlabsdevops-svc-devops
Bot
removed
the
CTT Requested (Full Set)
|
CTT Jenkins job: |
Tamás Fraknói (tamas-fraknoi)
approved these changes
Sep 15, 2026
Peter Balogh (silabs-peterb)
approved these changes
Sep 15, 2026
Aydogan Ersoz (silabs-aydogane)
approved these changes
Sep 15, 2026
Márk Mihalik | SiliconLabs (silabs-MarkM)
merged commit Sep 16, 2026
77a20f5
into
SiliconLabsSoftware:main
12 checks passed
Márk Mihalik | SiliconLabs (silabs-MarkM)
deleted the
88-nls-misleadin-report-fix
branch
September 16, 2026 06:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Closes: #88
Change
NLS implementation didn't check the end devices' NLS support. This PR attempts to fix this behavior with an early failure.
Checklist
./ci/scripts/clang-tidy.sh checkhas been run locally (see CONTRIBUTING.md)