Skip to content

#83: Accept Node/Add/Abort during NM_WAIT_FOR_PROTOCOL - #85

Draft
Aydogan Ersoz (silabs-aydogane) wants to merge 1 commit into
SiliconLabsSoftware:mainfrom
silabs-aydogane:GH-83-Node-Add-Abort-has-no-effect-with-NM-stuck-in-NM_WAIT_FOR_PROTOCOL
Draft

Aydogan Ersoz (silabs-aydogane) wants to merge 1 commit into
SiliconLabsSoftware:mainfrom
silabs-aydogane:GH-83-Node-Add-Abort-has-no-effect-with-NM-stuck-in-NM_WAIT_FOR_PROTOCOL

Conversation

@silabs-aydogane

Copy link
Copy Markdown
Collaborator

Issue

Closes: #83

Change

  • Network management module handles abort event during NM_WAIT_FOR_PROTOCOL

Checklist

@silabs-aydogane Aydogan Ersoz (silabs-aydogane) added the On roadmap On the official roadmap and will be implemented by Silicon Labs label Sep 15, 2026
@silabs-aydogane Aydogan Ersoz (silabs-aydogane) added Bug Issue is a bug report Silicon Labs development PR contents developed by Silicon Labs CTT Requested (Smoke) CTT Smoke Testing is requested from CTT Automation labels Sep 15, 2026
@cursor

cursor Bot commented Sep 15, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Changes inclusion abort timing and cleanup in the network management FSM, which can affect partially joined nodes and MQTT add reports.

Overview
Node add abort during protocol wait is now handled in the network management state machine when inclusion is in NM_WAIT_FOR_PROTOCOL (after a node is found but before secure bootstrapping finishes).

On NM_EV_ABORT, the stack stops the Z-Wave add with ADD_NODE_STOP_FAILED, notifies upper layers via a new notify_node_add_aborted() callback (SL_STATUS_FAIL, empty DSK, no KEX failure), then enters the existing NM_SEND_NOP / self-destruct cleanup path instead of leaving abort unhandled in that state.

The MQTT node-add report path only renames the local security_failed flag to failed; reporting logic is unchanged (non-OK status or non-none KEX still yields fail with MQTT_REASON_NODE_ADD_SECURITY_FAIL).

Reviewed by Cursor Bugbot for commit 8814bce. Configure here.

@silabs-aydogane
Aydogan Ersoz (silabs-aydogane) force-pushed the GH-83-Node-Add-Abort-has-no-effect-with-NM-stuck-in-NM_WAIT_FOR_PROTOCOL branch from 8814bce to 3ad5aab Compare September 15, 2026 07:30
@silabs-aydogane
Aydogan Ersoz (silabs-aydogane) marked this pull request as draft September 15, 2026 08:19
@siliconlabsdevops-svc-devops siliconlabsdevops-svc-devops Bot removed the CTT Requested (Smoke) CTT Smoke Testing is requested from CTT Automation label Sep 15, 2026
@siliconlabsdevops-svc-devops

Copy link
Copy Markdown

CTT Jenkins job: $zpc_ctt_jenkins_url/job/zw-ctt-automation-multibranch/job/main/3711/

…OCOL

Signed-off-by: Aydogan Ersoz <aydogan.ersoz@silabs.com>
@silabs-aydogane
Aydogan Ersoz (silabs-aydogane) force-pushed the GH-83-Node-Add-Abort-has-no-effect-with-NM-stuck-in-NM_WAIT_FOR_PROTOCOL branch from 3ad5aab to 27cd70d Compare September 16, 2026 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Issue is a bug report On roadmap On the official roadmap and will be implemented by Silicon Labs Silicon Labs development PR contents developed by Silicon Labs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Node/Add/Abort has no effect with NM stuck in NM_WAIT_FOR_PROTOCOL

2 participants