You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Medium Risk
Public API signature change for Silabs MqttClient; behavior depends on config defaults (QoS1) rather than per-call QoS, so misconfigured Init could silently use wrong QoS.
Overview Silabs MQTT QoS is now set once in MqttClientConfig instead of on every Subscribe/Publish call.
Adds MqttClientConfig::qos (default QoS1) for subscribe and publish; willQoS stays separate for Last Will when willEnable is true. MqttClient::Subscribe and Publish drop the per-call MqttQoS argument and use mConfig.qos after Init. Docs in mqtt_client.h note that apps can pick QoS0/QoS1 via config defaults only.
The thermostat Silabs MQTT demo stops passing hardcoded MqttQoS::QoS1 and relies on config defaults (with a short comment at init).
Breaking change: any caller must update signatures—Subscribe(topic, callback) and Publish(topic, payload, retained, callback).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MqttClientConfig::qosso Subscribe/Publish QoS is selected from config (QoS0/QoS1) instead of a per-call argument.MqttClient::Subscribe/Publishto usemConfig.qosafterInit.MqttQoSat the call site).willQoSremains Last Will–only (used whenwillEnableis true) and is independent of application Subscribe/Publish QoS.Related issues
NA
Testing
Tested with 917SoC thermostat dual stack app with QoS0 and QoS1 enabled
QoS0
QoS1