Skip to content

NOJIRA: Fix the OT-RCP builds - #965

Open
chirag-silabs wants to merge 1 commit into
release_2.10-1.6.1from
bugfix/fix_ot_rcp
Open

chirag-silabs wants to merge 1 commit into
release_2.10-1.6.1from
bugfix/fix_ot_rcp

Conversation

@chirag-silabs

Copy link
Copy Markdown
Contributor

Issue Link:
NA

Description of Problem/Feature:
The OT-RCP builds are failing due to the rename of the path in the SiSDK

Description of Fix/Solution:
Correcting the path in the ot-rcp script with the latest SiSDK

Testing Done:
Ran the script locally

@chirag-silabs
chirag-silabs requested a review from a team as a code owner August 3, 2026 05:06
@cursor

cursor Bot commented Aug 3, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Single build-script path change with no runtime, security, or product logic impact.

Overview
Updates build_ot_rcp.py so slc generate points at the OpenThread RCP project under the renamed SiSDK tree.

The slcp_file_path segment changes from openthread_app/ot-ncp/ot/ot-rcp.slcp to thread_app/ot-ncp/ot/ot-rcp.slcp, matching the current SDK layout and restoring OT-RCP binary builds that were failing on the old path.

Reviewed by Cursor Bugbot for commit 1857190. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Just curious was this change done recently? and do we have any checks in the CICD to identify path changes?
Just a suggestion, we should have a sanity check for checking for filepaths and not build the project, to bring out such misses earlier.

@Sarthak-Shaha

Copy link
Copy Markdown
Contributor

LGTM

Just curious was this change done recently? and do we have any checks in the CICD to identify path changes? Just a suggestion, we should have a sanity check for checking for filepaths and not build the project, to bring out such misses earlier.

They made the change for 26Q4 release,
We only run ot-rcp as manual trigger and hence not caught earlier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants