Skip to content

[NOJIRA] Support for Arm SLT and zap - #1057

Open
sarthak shaha (Sarthak-Shaha) wants to merge 5 commits into
release_2.9-1.6from
slc_cli/26q2-patch2
Open

sarthak shaha (Sarthak-Shaha) wants to merge 5 commits into
release_2.9-1.6from
slc_cli/26q2-patch2

Conversation

@Sarthak-Shaha

@Sarthak-Shaha sarthak shaha (Sarthak-Shaha) commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Issue Link:
[NOJIRA]

Description of Problem/Feature:
Need to use machine specific zap and slt

Description of Fix/Solution:
Updated to use machine() to get machine specific slt and zap

Testing Done:
https://github.com/SiliconLabsSoftware/matter_extension/actions/runs/34620304216
CI

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 11, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-11T16:10:38.297050Z d8cbdbc PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d8cbdbc5c4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "Codex (@codex) review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".

Comment thread slc/sl_setup_env.py Outdated
Comment thread slc/sl_setup_env.py
@Sarthak-Shaha

Copy link
Copy Markdown
Contributor Author

bugbot run

@cursor

cursor Bot commented Sep 11, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Only affects local/CI tool bootstrap URLs in the setup script; no runtime product or security paths change, with main risk being a wrong arch label on an unsupported host.

Overview
sl_setup_env.py now picks SLT CLI and ZAP download URLs from the host CPU instead of always using x64.

On macOS it sets host_arch via platform.machine() (arm64 vs x64) and uses that in the zip names. SLT CLI is bumped from 1.1.1 to 1.2.2. Platform handling in set_platform_vars is slightly cleaned up to use self.platform consistently.

Reviewed by Cursor Bugbot for commit 749f7be. Configure here.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 749f7be. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants