-
-
Notifications
You must be signed in to change notification settings - Fork 1
feat: fix env vars and tidy #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
7de657c
feat: pass Chatwoot env vars to web (no-op when unset)
taobojlen c881717
chore: untrack per-deployment Haraka me hostname, ship template
taobojlen b71d5a9
feat: opt-in Bunny DNS-01 TLS for Caddy
taobojlen 0089aba
caddy: track caddy-permissive-file-storage @main
taobojlen ada1bec
caddy: keep EMAIL_DOMAIN on HTTP-01 acme in Caddyfile.bunny
taobojlen 2d95deb
fix: pin Watchtower DOCKER_API_VERSION for Docker Engine 28+
taobojlen 268750c
caddy: drop verbose pin-rationale comment from Dockerfile
taobojlen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| { | ||
| # Global options | ||
| storage permissive_file_storage { | ||
| root "/data" | ||
| } | ||
|
|
||
| email {$ADMIN_EMAIL} | ||
| } | ||
|
|
||
| {$APP_DOMAIN} { | ||
| reverse_proxy web:8080 | ||
| tls { | ||
| dns bunny {env.BUNNY_API_KEY} | ||
| } | ||
| } | ||
|
|
||
| {$EMAIL_DOMAIN} { | ||
| tls { | ||
| issuer acme | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| # Compile Caddy with custom modules. | ||
| # - caddy-permissive-file-storage: world-readable certs so the cron | ||
| # sidecar can bundle them for Haraka (the whole reason this fork exists). | ||
| # - caddy-dns/bunny: DNS-01 ACME via Bunny.net, opt-in via Caddyfile.bunny. | ||
| FROM caddy:2.10-builder AS builder | ||
|
|
||
| RUN xcaddy build v2.10.0 \ | ||
| --with github.com/Shroud-email/caddy-permissive-file-storage@main \ | ||
| --with github.com/caddy-dns/bunny@v1.2.0 | ||
|
|
||
| # Production image | ||
| FROM caddy:2.10-alpine | ||
|
|
||
| COPY --from=builder /usr/bin/caddy /usr/bin/caddy | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| example.com |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2: Build reproducibility and supply-chain risk: pinning to
@maininstead of a specific commit hash makes the build non-deterministic. Everydocker compose up --build caddyrun pulls whatever is latest on the upstreammainbranch at that moment, so two builds at different times may produce different Caddy binaries — and any push to that repo'smain(even an accidental force-push or a future incompatible change) could silently break the build for all self-hosters. The previous pin to commit4059a602was more robust. Consider restoring a commit-hash pin and keeping the explicitReplace with @v0.1.5reminder, so there is a stable known-good point while awaiting the release.Prompt for AI agents