Gate agent workflows on trusted authors - #2443
Draft
devi-labs wants to merge 1 commit into
Draft
Conversation
## Summary Prevent write-capable agent workflows from running on externally authored issues or PRs, even when a trusted actor triggers them. Add environment approvals for higher-risk agent jobs while allowing naqvitalha to bypass that approval path for now. ## Approach - Require issue and PR authors to be OWNER, MEMBER, or COLLABORATOR before agent workflows can run. - Add approval jobs for agent-fix, agent-bot, and agent-android-bot using GitHub Environments. - Keep existing trigger-actor permission checks and prompt-injection scan headers in place. Co-authored-by: gpt-5.5 <noreply@shopify.com> Orchestrated-by: ae <noreply@shopify.com> Assisted-By: devx/1eb1773d-0aa4-4609-9e57-479a175eed30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent write-capable agent workflows from running on externally authored issues or PRs, even when a trusted actor triggers them. Add GitHub Environment approval gates for the higher-risk agent jobs, with
naqvitalhaas the only approval-bypass actor for now.Approach
OWNER,MEMBER, orCOLLABORATORbefore agent workflows can run.agent-fix,agent-bot, andagent-android-botusing GitHub Environments.Validation
ruby -e 'require "yaml"; ARGV.each { |f| YAML.load_file(f) }; puts "all workflow yaml ok"' .github/workflows/*.ymlgit diff --check -- .github/workflows/agent-triage.yml .github/workflows/agent-fix.yml .github/workflows/agent-bot.yml .github/workflows/agent-android-bot.ymldev checkreports no checks configured for this repo.Deployment note
The approval environments must be configured in GitHub repository settings with required reviewers for the approval gates to pause runs:
agent-fixagent-botagent-android-botCo-authored-by: gpt-5.5 noreply@shopify.com
Orchestrated-by: ae noreply@shopify.com