Skip to content

fix: v2 item separator with inverted flashlist - #2438

Open
theeket wants to merge 1 commit into
Shopify:mainfrom
theeket:fix/inverted-separator
Open

fix: v2 item separator with inverted flashlist#2438
theeket wants to merge 1 commit into
Shopify:mainfrom
theeket:fix/inverted-separator

Conversation

@theeket

@theeket theeket commented Aug 11, 2026

Copy link
Copy Markdown

Description

When inverted is true, the ItemSeparatorComponent should be rendered before the item (vertical: top, horizontal: left) to make it render properly. Otherwise, the separator will be displayed at the wrong side.

This fix once landed on v1.6.4. However, the same behavior does not being carried over to v2.
#638, PR #1048

Reviewers’ hat-rack 🎩

  • [ ]

Screenshots or videos (if needed)

Example: inverted, horizontal

In the “Before” picture, the separator displayed at the right, so the last item (at the left) which doesn’t have a separator will displayed adjacently and the first item (at the right) will have extra space. In “After” picture, the separator displayed at the left, makes it correct.

Before:
01


After:
02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant