fix: run CI on all pull requests, not just those targeting main - #944
Merged
kdaviduik merged 1 commit intoMar 11, 2026
Merged
Conversation
This was referenced Mar 9, 2026
Contributor
Author
kdaviduik
marked this pull request as ready for review
March 9, 2026 20:40
This was referenced Mar 9, 2026
The pull_request trigger had `branches: [main]`, which meant CI only ran on PRs whose base branch is main. Stacked PRs (which target intermediate branches) never got CI coverage. Remove the branch filter so CI runs on every PR regardless of base branch. The push trigger retains `branches: [main]` — we only want push CI on main merges, not on every branch push.
kdaviduik
force-pushed
the
03-09-fix_run_ci_on_all_pull_requests_not_just_those_targeting_main
branch
from
March 10, 2026 01:37
bba962b to
8588844
Compare
kdaviduik
force-pushed
the
kd-update-to-typescript
branch
from
March 10, 2026 01:37
222f126 to
39ab920
Compare
fredericoo
approved these changes
Mar 11, 2026
andguy95
approved these changes
Mar 11, 2026
kdaviduik
deleted the
03-09-fix_run_ci_on_all_pull_requests_not_just_those_targeting_main
branch
March 11, 2026 15:48
This was referenced Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pull_request trigger had
branches: [main], which meant CI onlyran on PRs whose base branch is main. Stacked PRs (which target
intermediate branches) never got CI coverage. Remove the branch
filter so CI runs on every PR regardless of base branch.
The push trigger retains
branches: [main]— we only want pushCI on main merges, not on every branch push.