feat(inference): time-travel chart data to the selected run#459
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Found 6 test failures on Blacksmith runners: Failures
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Medium Risk
Changes core benchmark fetch and SQL filtering used by the main chart; behavior is covered by new tests but wrong cutoff logic could show stale or missing points.
Overview
The inference chart can now show benchmark data as of a selected GitHub workflow run, not only the latest sweep for a day.
Backend:
GET /api/v1/benchmarksaccepts an optional numericrunId. SQL and JSONgetLatestBenchmarksapply a run cutoff on the main chart’s date-filtered path (run_started_at≤ selected run), while keeping rows with null timestamps and skipping the filter forexact=trueGPU-comparison queries.Frontend: Run selection is resolved before chart fetch;
asOfRunIdis sent only when the user picks an earlier run than the latest for the model. That forces the dated query path (not the materialized-view shortcut) and extends React Query keys so per-run views don’t collide in cache.Reviewed by Cursor Bugbot for commit 8d047d0. Bugbot is set up for automated code reviews on this repo. Configure here.