Skip to content

chore: remove rss-reader leftovers#849

Merged
nicomiguelino merged 3 commits into
masterfrom
chore/remove-rss-reader-leftovers
Jun 21, 2026
Merged

chore: remove rss-reader leftovers#849
nicomiguelino merged 3 commits into
masterfrom
chore/remove-rss-reader-leftovers

Conversation

@nicomiguelino

@nicomiguelino nicomiguelino commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

User description

  • Remove stale initialize-rss-reader-app.yml workflow (superseded by Screenly/rss-reader-app)\n- Remove icon from old edge-apps/rss-reader/static/img/ location

PR Type

Other


Description

  • Remove obsolete RSS initialization workflow

  • Remove obsolete RSS update workflow

  • Clean up deprecated RSS automation


Diagram Walkthrough

flowchart LR
  A["RSS reader GitHub workflows"] -- "removed" --> B["No repository-managed RSS automation"]
  C["Initialize workflow"] -- "deleted" --> B
  D["Update workflow"] -- "deleted" --> B
Loading

File Walkthrough

Relevant files
Configuration changes
initialize-rss-reader-app.yml
Delete RSS reader initialization workflow                               

.github/workflows/initialize-rss-reader-app.yml

  • Deleted manual RSS reader initialization workflow.
  • Removed environment-specific app creation and deployment steps.
  • Removed manifest customization and instance creation automation.
+0/-120 
update-rss-reader-apps.yml
Delete RSS reader update workflow                                               

.github/workflows/update-rss-reader-apps.yml

  • Deleted manual RSS reader update workflow.
  • Removed app matrix generation from deployed-apps.yml.
  • Removed per-app manifest override and deployment automation.
  • Removed deployment summary job.
+0/-181 

- remove stale initialize-rss-reader-app.yml workflow
- remove icon from old rss-reader location
@github-actions

github-actions Bot commented Jun 21, 2026

Copy link
Copy Markdown

PR Reviewer Guide 🔍

(Review updated until commit 630f0d4)

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected

@github-actions

Copy link
Copy Markdown

PR Code Suggestions ✨

No code suggestions found for the PR.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes remaining artifacts of the deprecated in-repo RSS Reader Edge App, which has been moved to Screenly/rss-reader-app.

Changes:

  • Deleted the legacy GitHub Actions workflow used to initialize RSS Reader deployments.
  • Deleted the legacy GitHub Actions workflow used to update RSS Reader deployments.
  • Removed the old RSS Reader icon asset from the former edge-apps/rss-reader/static/img/ location.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
edge-apps/rss-reader/static/img/icon.svg Removes the obsolete icon asset from the legacy RSS Reader app path.
.github/workflows/update-rss-reader-apps.yml Removes the deprecated RSS Reader update workflow that depended on the old app location/config.
.github/workflows/initialize-rss-reader-app.yml Removes the deprecated RSS Reader initialization workflow for manual app setup.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@nicomiguelino nicomiguelino marked this pull request as ready for review June 21, 2026 08:53
@github-actions

Copy link
Copy Markdown

Persistent review updated to latest commit 630f0d4

@github-actions

Copy link
Copy Markdown

PR Code Suggestions ✨

No code suggestions found for the PR.

@nicomiguelino nicomiguelino merged commit 2817d49 into master Jun 21, 2026
4 checks passed
@nicomiguelino nicomiguelino deleted the chore/remove-rss-reader-leftovers branch June 21, 2026 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants