Fix default verbosity in NNODE and NNSDE - #1108
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
|
Local validation for Reproduction and regressionWith DiffEqBase 7.13.0, omitting The NNODE failure was at Test matrixI ran each group independently with a six-hour shell timeout using this command shape (with the listed Julia channel, group, and isolated depot): env GROUP=<group> JULIA_DEPOT_PATH=<depot> \
timeout 21600 /home/crackauc/.juliaup/bin/julia +<channel> \
--startup-file=no --color=no --project=. \
-e 'using Pkg; Pkg.test(; julia_args = ["--startup-file=no"])'Results:
Every run executed the complete selected group and ended with Docs investigationThe unmodified full docs path on clean base Formatting/home/crackauc/.julia/juliaup/julia-1.12.6+0.x64.linux.gnu/bin/julia \
--startup-file=no \
--project=/home/crackauc/sandbox/tmp_20260708_051717_3275/qa-artifacts/runic-julia-env \
-e 'using Runic; exit(Runic.main(ARGS))' -- --check --diff \
src/ode_solve.jl src/NN_SDE_solve.jl \
test/NNODE/nnode__scalar.jl \
test/NNSDE1/nn_sde__test_1_solve_autodiff.jl
git diff --check HEAD^ HEADBoth commands exited 0 against the pushed commit. |
|
Current CI failure classification:
I am not adding these unrelated fixes to this focused default-verbosity PR. The affected |
|
This should instead update to preferring the DEVerbosity / SciMLLogging. |
Summary
DEVerbositydefault in the NNODE and NNSDE optimization callbacksverbose = trueverbosein the NNODE and NNSDE solver testsRoot cause
The callbacks assumed that the
verbosekeyword was always aBool. DiffEqBase commit6853462changed the v7solvedefault toDEFAULT_VERBOSE, aDEVerbosity. NeuralPDE opened DiffEqBase/OrdinaryDiffEq v7 compatibility in5c011a7without adapting these pre-existing callbacks, so an ordinarysolve(prob, NNODE(...))orsolve(prob, NNSDE(...))reached a non-Boolean value inif verbose.The local progress output remains an explicit opt-in: only the literal
verbose = trueenables it. This matches the existing SDEPINN compatibility handling.Issue #1105 currently records a separate numerical assertion failure in the data-collocation tutorial. This PR fixes the default-verbosity defect found during that investigation and does not close #1105.
Validation
TypeError: non-boolean (DiffEqBase.DEVerbosity...) used in boolean contextin both NNODE and NNSDE with Julia 1.12.6 and DiffEqBase 7.13.0@examplecontaining both omitted-verbosesolves on Julia 1.12.6 and Julia 1.10.11NNSDE1/nn_sde__test_1_solve_autodiff.jlon Julia 1.12.6, 1.11.9, and 1.10.11git diff --checkIgnore this PR until it has been reviewed by @ChrisRackauckas.