Revert the classical_physics example-group split - #905
Merged
Conversation
Reverts #904. It broke the docs build on master. Splitting the shared `@example physics` block into per-topic groups gives each group its own module, so every name a group uses must be defined *within that group*. #904 fixed one escapee (`ODERKN`) but not all of them: the `double-pendulum` group also uses `g`, which is defined in an earlier block, so `makedocs` fails with ``` UndefVarError: `g` not defined in `Main.var"__atexample__named__double-pendulum"` ``` and the following block then cascades on `sol`. Restoring the single `physics` group unbreaks the build. The split is still worth doing — it is a real readability improvement — but it needs every cross-block name resolved first, which is best verified by a full docs build before merging rather than after. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014FEzNTLFutCmTEAZ3zBg5R
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #904. It broke the docs build on master.
Splitting the shared
@example physicsblock into per-topic groups gives each group its ownmodule, so every name a group uses must be defined within that group. #904 fixed one escapee
(
ODERKN) but not all of them: thedouble-pendulumgroup also usesg, which is defined inan earlier block, so
makedocsfails withand the following block then cascades on
sol.Restoring the single
physicsgroup unbreaks the build. The split is still worth doing — it isa real readability improvement — but it needs every cross-block name resolved first, which is
best verified by a full docs build before merging rather than after.
🤖 Generated with Claude Code
https://claude.ai/code/session_014FEzNTLFutCmTEAZ3zBg5R