Use explicit form of Hamiltonian derivative in Kepler problem - #892
Merged
Conversation
Since the equations of motion are defined through the derivatives of the Hamiltonian in the code, `RKNFirstDerivativeSentinel` for using the `DPRKN6` and `ERKN4` solvers error because they get a dependence of the first derivative (`p`) from the position variable (`q`). (I think.) Explicitly stating the equations of motion for ṗ and q̇ circumvents the problem and lets the documentation build, at the cost of making it a bit more obtuse. But I added the derivatives in the LaTeX block to help with that. Also makes the imports explicit by just importing the used names because it was getting to be a pain to preface everything.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Additional context
Since the equations of motion are defined through the derivatives of the Hamiltonian in the code,
RKNFirstDerivativeSentinelfrom using theDPRKN6andERKN4solvers error because they get a dependence of the first derivativepfrom the position variableq(I think). Explicitly stating the equations of motion for ṗ and q̇ circumvents the problem and lets the documentation build, at the cost of making it a bit more obtuse. But I added the derivatives in the LaTeX block to help with that.Also makes the imports explicit by just importing the used names because it was getting to be a pain to preface everything.