Skip to content

Activate corrected conservation-law tests #1512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisRackauckas merged 1 commit into from
Jul 29, 2026
+7 −7
Merged

Activate corrected conservation-law tests #1512

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions test/network_analysis/conservation_laws.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,9 +147,9 @@ let
@test nsol1[sps] ≈ nsol1b[sps]
@test nsol1[sps] ≈ nsol2[sps]
@test nsol1[sps] ≈ nsol2b[sps]
@test_broken nsol1[sps] ≈ sssol1[sps]
@test nsol1[sps] ≈ sssol1[sps]
@test nsol1[sps] ≈ sssol2[sps]
@test_broken nsol1[sps] ≈ sssol3[sps]
@test nsol1[sps] ≈ sssol3[sps]
end

# Creates SDEProblems using various approaches.
Expand All @@ -176,11 +176,11 @@ let
sprob1.f(du1, sprob1.u0, sprob1.p, 1.0)
sprob2.f(du2, sprob2.u0, sprob2.p, 1.0)
sprob3.f(du3, sprob3.u0, sprob3.p, 1.0)
@test_broken du1 ≈ du2[ind_uidxs] ≈ du3
@test du1 ≈ du2[ind_uidxs] ≈ du3
sprob1.g(g1, sprob1.u0, sprob1.p, 1.0)
sprob2.g(g2, sprob2.u0, sprob2.p, 1.0)
sprob3.g(g3, sprob3.u0, sprob3.p, 1.0)
@test_broken g1 ≈ g2[ind_uidxs, :] ≈ g3
@test g1 ≈ g2[ind_uidxs, :] ≈ g3
end

# Tests simulations for various input types (using X, rn.X, and :X forms).
Expand Down Expand Up @@ -284,10 +284,10 @@ let

# Check `ODEProblem` content.
@test oprob[X1] == 1.0
@test_broken oprob[X2] == 2.0
@test oprob[X2] == 2.0
@test oprob.ps[k1] == 0.1
@test oprob.ps[k2] == 0.2
@test_broken oprob.ps[Γ[1]] == 3.0
@test oprob.ps[Γ[1]] == 3.0

# Update (normal) problem parameters using `remake`.
oprob_new = remake(oprob; p = [k1 => 0.3, k2 => 0.4])
Expand Down Expand Up @@ -322,7 +322,7 @@ end
nsol = solve(nprob)
@test oprob[:X] == sprob[:X] == nprob[:X] == 2.0
@test osol[:X][1] == ssol[:X][1] == 2.0
@test_broken oprob[:X2] == sprob[:X2] == nprob[:X2] == 3.0
@test oprob[:X2] == sprob[:X2] == nprob[:X2] == 3.0
@test osol[:X2][1] == ssol[:X2][1] == 3.0
#@test oprob.ps[:Γ][1] == sprob.ps[:Γ][1] == nprob.ps[:Γ][1] == 4.0
@test osol.ps[:Γ][1] == ssol.ps[:Γ][1] == nsol.ps[:Γ][1] == 4.0
Expand Down
Loading