Repository navigation
chore: sync bindings in README, config and code - #788
Merged
Merged
Conversation
RobertMueller2
approved these changes
Oct 26, 2026
Collaborator
Author
|
Please do not miss: Question actions_on_enter - should we follow:
Currently I added it in the code - which is a breaking change. 🤔 |
Member
I have not missed it ;) I was too lazy to type while on mobile earlier. It's definitely justifiable to add it if the documentation says it's there. Since nobody has complained about it, it's just as justifiable to remove it from the documentation. Believe it or not,I don't think I have an opinion on this. ;) |
Collaborator
Author
|
Ok, then we keep it like this - IMHO it does no harm - if the documented behavior would have been "exit" I would have decided the other way around ;-) So let's merge it now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
They were not in sync.
Question actions_on_enter - should we follow:
Checklist