Skip to content

feat/match typed key also - #772

Open
robertwidfen wants to merge 1 commit into
Satty-org:mainfrom
robertwidfen:feat/match-typed-key-also
Open

robertwidfen wants to merge 1 commit into
Satty-org:mainfrom
robertwidfen:feat/match-typed-key-also

Conversation

@robertwidfen

@robertwidfen robertwidfen commented Oct 24, 2026 •

Copy link
Copy Markdown
Collaborator

Description

More freedom in bindings, e.g. "equal" will bind in all layouts,
in DE it is actually the physical key combo Ctrl+Shift+0, on US it is just Ctrl+=.

Checklist

  • I've read CONTRIBUTING.md and AI_POLICY.md
  • all commits compile
  • PR title uses (conventional commit message)[https://www.conventionalcommits.org/]
  • any merge conflicts were resolved via rebase rather than merge
  • includes LLM/Generative AI generated code
    • I understand the code on a technical level
    • I vouch for the code

@robertwidfen
robertwidfen requested review from a team October 24, 2026 12:14
@robertwidfen

Copy link
Copy Markdown
Collaborator Author

See #771 at the end why I think it should be done like this...

@robertwidfen
robertwidfen marked this pull request as draft October 24, 2026 12:22
@robertwidfen

Copy link
Copy Markdown
Collaborator Author

Make it a draft until #711 gets merged and it is verified to not break anything again.

@robertwidfen
robertwidfen force-pushed the feat/match-typed-key-also branch from 95a06fe to 7c80494 Compare October 24, 2026 17:27
@robertwidfen
robertwidfen force-pushed the feat/match-typed-key-also branch from 7c80494 to 60b9f32 Compare October 24, 2026 22:25
@robertwidfen

Copy link
Copy Markdown
Collaborator Author

@rokokol can you please take a look 🙏🏻

@robertwidfen
robertwidfen marked this pull request as ready for review October 26, 2026 08:00
@rokokol

rokokol commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

LGTM, good work! Tested it manually with us and ru layouts, everything works. Tests, clippy and fmt pass too

Two small things: no keymap test covers the Shift case yet, so maybe add one like DE Ctrl+Shift+0 → Zoom. And did you mean #771 instead of #711?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants