Repository navigation
feat: system wide config - #667
Merged
Merged
Conversation
Closes: Satty-org#630 Changes configuration.rs code slightly to allow a system wide config file in XDG_CONFIG_DIRS/satty/config.toml (usually /etc/xdg/satty/config.toml). File not found on any specified config (--config) is still fatal, I think this is sensible. For the system and user config, they're used if present and skipped via external BaseDirectories::find_config_files if not present. This PR clashes with Satty-org#664. Design choices: - shortcuts are extended (I suppose it would suck if this wasn't the case), there is always none to unset - fallback fonts vec is extended, additional fonts on user side wouldn't hurt much - palette and custom colours are overwritten. otherwise it might be tricky to prevent a full style toolbar on user side, depending on how many entries packagers provide via system config. I didn't feel like providing any special notation to clear this.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #630
Changes configuration.rs code slightly to allow a system wide config file in XDG_CONFIG_DIRS/satty/config.toml (usually /etc/xdg/satty/config.toml).
File not found on any specified config (--config) is still fatal, I think this is sensible. For the system and user config, they're used if present and skipped via external BaseDirectories::find_config_files if not present.
This PR clashes with #664.
Design choices: