Repository navigation
fix(squawk): let the poll be removed when the system asks for reduced motion - #317
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported in general support: a poll added to a Squawk post by accident could not be removed.
Cause
Removing a poll only sets
pollClosing. The poll is cleared inonAnimationEndoncesq-poll-outfinishes. Underprefers-reduced-motion: reducethe composer sets.sq-poll { animation: none !important }, so that event never fires and the poll stays. Chromium reports reduced motion when Windows "Animation effects" is off, which the "Adjust for best performance" preset also turns off.The poll draft lives in session state (
birdy:composerPoll), so it also came back every time the composer was reopened, until the UI reloaded.Fix
togglePollclears the poll straight away when reduced motion is on, the same way the admin panel's sheets close (admin/ui.tsx). Otherwise the fold-out animation plays as before.No other component pairs a reduced-motion
animation: nonewith state that waits ononAnimationEnd.Verified
Composer mounted from the dev server, with reduced motion emulated:
Tested in game with Windows Animation effects on and off.
Gates
tsc --noEmit: passoxlint: 0 errors, 24 existing warningsknip: passi18n:check: passvitest: 885/885