Repository navigation
Improve dev controls and player detail loading - #315
Closed
TheBlackWraiths wants to merge 3 commits into
Closed
TheBlackWraiths wants to merge 3 commits into
TheBlackWraiths wants to merge 3 commits into
Conversation
Group development controls in the app, including boot replay and admin access. Normalize missing player overview lists so characters without phone profiles load safely.
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Group development controls in the app, including boot replay and admin access. Normalize missing player overview lists so characters without phone profiles load safely.
Summary
top-[84px], and Replay boot covered Show Setup. They now sit in one wrapping toolbar at the top-left, still dev builds only.sd-phone:admin:open, so the admin panel can be opened from the dev preview.BootReplayButtonnow renders an inline button instead of a fixed-position portal, and the toolbar places it.Cannot read properties of undefined (reading 'length')for characters whose overview was missing lists, such as characters with no phone profile.accounts,birdy,mutes,downloadableandsim.simsnow default to empty arrays when the overview loads.Type of Change
Related Issues
Related to the admin player details fix in 66614ff (characters with no phone profile).
Testing
To check:
bun run buildinweb/) for the crash fix to take effect in-game.Breaking Changes
The toolbar is dev-only, and the overview change only adds defaults for missing lists.
Checklist