Repository navigation
fix(themes): blank most-sales-products page when sort options are missing - #1045
Merged
sallainternalbot[bot] merged 1 commit intoSep 12, 2026
Merged
Conversation
Five views map to this template and most-Sales-products is the one that never passes sort_options, so the filter call received null and the page rendered blank.
Contributor
Up to standards ✅🟢 Issues
|
Member
Author
|
/merge |
Contributor
⏳ Enqueued for MergeYour pull request has been added to the merge queue. It will be merged automatically once it reaches the front of the queue ✅ 🔄 Queue Status🚦 QueueThe queue is empty. Good luck! 🧬 PR's Dependencies |
Contributor
🔄 Merge In ProgressThis pull request has reached the front of the queue and is now being processed for merge. |
sallainternalbot
Bot
deleted the
bugfix/TD-16291-blank-most-sales-products-page
branch
September 12, 2026 17:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behaviour? (You can also link to an open issue here)
/most-Sales-productsrenders a blank page (HTTP 200, empty body) on ~647 stores.ComponentsController::displayMostSalesProductshand-builds['products', 'page_title']and never passessort_options, unlike the other render sites that go throughHasCategoryPageData::getData().sort_optionsis therefore null and|filterthrowsTwig\Error\RuntimeError: The "filter" filter expects an array or "Traversable", got "NULL".What is the new behaviour? (You can also link to the ticket here)
sort_options|default([])before the filter, so a missing value renders an emptysort-byinstead of throwing. No change to any case that already worked.Does this PR introduce a breaking change?
Screenshots (If appropriate)