You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
feat(TD-16254): show the selected barcode in the storefront product details - #1043
Fixes the English barcode label, which shipped as the Arabic string and rendered "الباركود" on English storefronts.
Keys the SKU and barcode rows on the new product.shows_sku / product.shows_barcode flags rather than on the value, so a row the parent product leaves empty still exists (hidden) and is revealed when the customer picks a variant that carries a value. product.js now updates the barcode alongside the SKU on every variant change, hiding the whole row instead of leaving a labelled empty one, and long values wrap instead of overflowing on mobile.
Must deploy after the Store PR below — product.shows_sku resolves to null until that whitelist is live, which would drop the SKU row.
…tails
Fix the English barcode label, which shipped as the Arabic string and rendered
"الباركود" on English storefronts.
Key the identifier rows on the new product.shows_sku / product.shows_barcode
flags rather than on the value, so a row that the parent product leaves empty
still exists (hidden) and can be revealed when the customer picks a variant
that carries a value. product.js now updates the barcode alongside the SKU on
every variant change, hiding the whole row instead of leaving a labelled empty
one, and long values wrap instead of overflowing.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016MtMatBNJ4msTomRC9SReY
AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
Codacy flagged the innerHTML assignment carried over from the SKU update path as
an XSS vector for merchant-supplied values. textContent is also what the ticket
specifies: the identifier renders as plain text exactly as recorded, with nothing
added by the system.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016MtMatBNJ4msTomRC9SReY
This repo commits its built assets alongside the sources, so the JS change would
never have reached the storefront without them: public/product.js carries the
barcode row update and public/app.js the multiSelectors entry that makes
app.element() return a NodeList for .product-barcode.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016MtMatBNJ4msTomRC9SReY
moharram82
changed the title
feat(catalog): show the selected barcode in the storefront product details
feat(TD-16254): show the selected barcode in the storefront product details
Sep 7, 2026
The toggled wrapper carried `flex sm:grid` alongside `hidden`. All three are
display rules of equal specificity, and `sm:grid` sits in a media query far
later in the stylesheet, so above 640px it beat `hidden` and the row rendered as
an empty labelled card. The card's layout classes move to an inner element,
leaving `hidden` unopposed on the wrapper the twig and product.js toggle.
Rows are also keyed on the reworked shows_* flags, which now drop a row entirely
when neither the product nor any variant can fill it.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016MtMatBNJ4msTomRC9SReY
AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
moharram82
changed the title
Fixes the English barcode label, which shipped as the Arabic string and rendered "الباركود" on English storefronts.
Keys the SKU and barcode rows on the new
product.shows_sku/product.shows_barcodeflags rather than on the value, so a row the parent product leaves empty still exists (hidden) and is revealed when the customer picks a variant that carries a value.product.jsnow updates the barcode alongside the SKU on every variant change, hiding the whole row instead of leaving a labelled empty one, and long values wrap instead of overflowing on mobile.Must deploy after the Store PR below —
product.shows_skuresolves to null until that whitelist is live, which would drop the SKU row.Ticket: TD-16254