feat(CPD-32641): support PHPUnit 10 through 12 by thaifanisalla · Pull Request #80 · SallaApp/ZATCA

thaifanisalla · 2026-09-27T14:05:20Z

Part of the zatca-einvoicing Laravel 13 upgrade (CPD-32641).

What kind of change does this PR introduce?

Test tooling fix. No production code is touched.

What is the current behaviour?

Every test method in this suite is marked with /** @test */. PHPUnit 12 removed metadata in doc-comments, so those methods are no longer collected — the suite does not fail, it reports nothing. Consumers that run the package tests as part of their own suite (zatca-einvoicing includes vendor/salla/zatca/tests in its phpunit.xml) went from 8 ZATCA tests to 0 without any signal while upgrading to Laravel 13 / PHPUnit 12.

phpunit.xml is also PHPUnit 8/9-era: backupStaticAttributes, verbose, convertErrorsToExceptions, convertNoticesToExceptions, convertWarningsToExceptions and filter/whitelist were all removed in PHPUnit 10, so the config itself will not load there.

What is the new behaviour?

the 8 test methods across SignInvoiceTest, GenerateCSRTest and GenerateQrCodeTest use #[Test]
phpunit/phpunit moves from ~8.0 to ^10.5|^11.5|^12.0
phpunit.xml is rewritten for the PHPUnit 10+ schema (filter/whitelist → <source>). The gating the removed convert*ToExceptions flags provided is kept through their PHPUnit 10+ equivalents, failOnNotice and failOnWarning, so a notice or warning still fails the build
cacheDirectory is set (and gitignored) so PHPUnit stops warning about the default cache location

Verified locally: 8 tests, 26 assertions green on PHPUnit 12.5.35 / PHP 8.3, with failOnNotice/failOnWarning active — previously 0 collected.

PHP requirement

Unchanged: require.php stays >=8.0. src/ and tests/ both lint clean on php:8.0-cli, so the consumer-facing floor has no reason to move — that contract describes what the library runs on, not what its test tooling needs.

Developing the package does now need PHP 8.1, because phpunit/phpunit ^10.5 is the lowest line that reads attribute metadata. require-dev is root-only, so this affects contributors on an end-of-life runtime, not anyone installing the package.

(The sibling PR SallaApp/E-Invoicing#30 does raise its floor to >=8.1 — that package's src/ declares final public const and fatals on 8.0, so its >=8.0 was already inaccurate. This one is genuinely 8.0-clean.)

Does this PR introduce a breaking change?

No. Test-only; the published src/ and the declared PHP floor are both unchanged.

Follow-up

zatca-einvoicing pins salla/zatca: ~3.0 (locked at 3.0.5) while master is tagged 4.0.1, so this fix needs either a 3.0.x patch release or a decision to move that app to ^4.0.

Confidence Score: 5/5

The PR appears safe to merge; no actionable issue was identified.

Summary

The PR updates the package’s test tooling for PHPUnit 10–12 without changing production code or the declared PHP runtime requirement.

Replaces doc-comment test markers with #[Test] attributes across eight test methods.
Updates the PHPUnit dependency constraint and configuration, and ignores PHPUnit cache files.
Greptile automatically discovered a related ticket that helped explain the purpose of this PR: verifying ZATCA compatibility as part of the Laravel 13 upgrade.

_{Reviews (11) · Last reviewed commit: "chore: trigger unit tests [utest]"}

@test

PHPUnit 12 removed doc-comment metadata. Every test in this package is marked with `/** @test */`, so under PHPUnit 10 or newer none of the 8 tests is collected any more: the suite reports success while running nothing, both here and in every application that includes this package's tests in its own suite. Replace the annotation with the `#[Test]` attribute, supported since PHPUnit 10. require-dev pinned phpunit/phpunit at ~8.0, which cannot be installed alongside a modern application; widen it to ^10.5|^11.5|^12.0. PHPUnit 10.5 needs PHP 8.1, but that is a require-dev concern only: this package's src/ and tests/ both lint clean on php:8.0-cli, so require.php stays at the consumer floor of 8.0. A dev install needs PHP 8.1, which is where the supported PHPUnit line starts. phpunit.xml is rewritten for the PHPUnit 10+ schema: the removed attributes (backupStaticAttributes, verbose, convertErrorsToExceptions and friends) are dropped and the filter/whitelist block becomes `<source>`. The gating those convert* flags provided is kept through their PHPUnit 10+ equivalents, failOnNotice and failOnWarning, so a notice or warning still fails the build.

codacy-production · 2026-09-27T14:06:08Z

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 duplication

Metric Results

Duplication ✅ 0 (≤ 2 duplication)

View in Codacy

AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.

_{TIP This summary will be updated as you push new changes.}

thaifanisalla · 2026-09-27T14:49:13Z

/utest

sallainternalbot · 2026-09-27T14:49:19Z

Unit Test Trigger Summary

Triggered PRs:

feat(CPD-32641): support PHPUnit 10 through 12 #80 — unit tests triggered.

ahmed3mar · 2026-10-06T06:56:20Z

/canmerge

sallainternalbot · 2026-10-06T06:56:26Z

⚠️ Merge Blocked

I wasn't able to complete the merge due to the following issues:

👥 Missing Required Approvals

These PRs need to be approved by reviewers:

feat(CPD-32641): support PHPUnit 10 through 12 #80 requires approval from @salkhwlani, @ajibadeabd, @shamoon1997, @EngRashaAmer, @jamalla2

Please request review and ensure all approvals are completed.

🎫 Missing or Invalid Ticket ID

The following PRs do not have a valid ticket ID in their title or branch name, or do not follow branch naming conventions:

feat(CPD-32641): support PHPUnit 10 through 12 #80 — Jira ticket CPD-32641 Upgrade Zatca to Laravel 13 has status Pending which does not match required pattern Preparing to Deploy

Please add a valid ticket ID (e.g., PROJ-123) and ensure branch naming conventions are followed.

⏰ Dependency PR Checks Are Stale

The following dependency PRs have commits newer than the latest test run on this PR. The test results may not reflect the current state of dependencies:

feat(CPD-32641): support PHPUnit 10 through 12 #80: no successful "Testing Ready" check run on root PR — run the tests first

Please re-run the test workflow or push a new commit to the main PR to trigger fresh checks.

Once all issues are resolved, you can try the merge again.
If anything seems off, feel free to ask for help — I've got your back! 🤖

EngRashaAmer · 2026-10-06T07:37:14Z

/merge

sallainternalbot · 2026-10-06T07:37:20Z

⚠️ Merge Blocked

I wasn't able to complete the merge due to the following issues:

⏰ Dependency PR Checks Are Stale

The following dependency PRs have commits newer than the latest test run on this PR. The test results may not reflect the current state of dependencies:

feat(CPD-32641): support PHPUnit 10 through 12 #80: no successful "Testing Ready" check run on root PR — run the tests first

Please re-run the test workflow or push a new commit to the main PR to trigger fresh checks.

Once all issues are resolved, you can try the merge again.
If anything seems off, feel free to ask for help — I've got your back! 🤖

EngRashaAmer · 2026-10-06T07:48:32Z

/merge

sallainternalbot · 2026-10-06T07:48:37Z

⚠️ Merge Blocked

I wasn't able to complete the merge due to the following issues:

⏰ Dependency PR Checks Are Stale

The following dependency PRs have commits newer than the latest test run on this PR. The test results may not reflect the current state of dependencies:

feat(CPD-32641): support PHPUnit 10 through 12 #80: no successful "Testing Ready" check run on root PR — run the tests first

Please re-run the test workflow or push a new commit to the main PR to trigger fresh checks.

Once all issues are resolved, you can try the merge again.
If anything seems off, feel free to ask for help — I've got your back! 🤖

EngRashaAmer · 2026-10-06T07:50:54Z

/merge

sallainternalbot · 2026-10-06T07:50:59Z

⚠️ Merge Blocked

I wasn't able to complete the merge due to the following issues:

⏰ Dependency PR Checks Are Stale

The following dependency PRs have commits newer than the latest test run on this PR. The test results may not reflect the current state of dependencies:

feat(CPD-32641): support PHPUnit 10 through 12 #80: no successful "Testing Ready" check run on root PR — run the tests first

Please re-run the test workflow or push a new commit to the main PR to trigger fresh checks.

Once all issues are resolved, you can try the merge again.
If anything seems off, feel free to ask for help — I've got your back! 🤖

thaifanisalla · 2026-10-06T07:51:26Z

/utest

sallainternalbot · 2026-10-06T07:51:32Z

Unit Test Trigger Summary

Triggered PRs:

feat(CPD-32641): support PHPUnit 10 through 12 #80 — unit tests triggered.

codacy-production · 2026-10-06T07:52:23Z

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 duplication

Metric Results

Duplication ✅ 0 (≤ 2 duplication)

View in Codacy

AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.

_{TIP This summary will be updated as you push new changes.}

Mustafa-Azzam-Salla · 2026-10-06T07:56:12Z

/utest

sallainternalbot · 2026-10-06T07:56:18Z

Unit Test Trigger Summary

Triggered PRs:

feat(CPD-32641): support PHPUnit 10 through 12 #80 — unit tests triggered.

…thub.com:SallaApp/ZATCA into feature/CPD-32641-upgrade-zatca-to-laravel-13-v2

thaifanisalla · 2026-10-06T10:04:37Z

/utest

sallainternalbot · 2026-10-06T10:04:42Z

Unit Test Trigger Summary

Triggered PRs:

feat(CPD-32641): support PHPUnit 10 through 12 #80 — unit tests triggered.

maqalaqil · 2026-10-06T10:12:45Z

/merge --bypass

sallainternalbot · 2026-10-06T10:12:53Z

The file composer.json detected in #80. Waiting for composer version to be available

sallainternalbot · 2026-10-06T10:20:54Z

Failed to bypass merge: failed to bypass merge: failed to find version for #80

thaifanisalla mentioned this pull request Sep 27, 2026

test(CPD-32641): support PHPUnit 10 through 12 #79

Closed

thaifanisalla marked this pull request as ready for review September 27, 2026 14:19

thaifanisalla requested a review from a team as a code owner September 27, 2026 14:19

thaifanisalla changed the title ~~test(CPD-32641): support PHPUnit 10 through 12~~ feat(CPD-32641): support PHPUnit 10 through 12 Sep 27, 2026

chore: trigger unit tests [utest]

6155555

ahmed3mar approved these changes Oct 6, 2026

View reviewed changes

EngRashaAmer approved these changes Oct 6, 2026

View reviewed changes

add code owner

56c7ef2

Mustafa-Azzam-Salla approved these changes Oct 6, 2026

View reviewed changes

chore: trigger unit tests [utest]

bbbc724

chore: trigger unit tests [utest]

c29076e

chore: trigger unit tests [utest]

a82baf2

sallainternalbot Bot and others added 8 commits October 6, 2026 08:07

chore: trigger unit tests [utest]

f25e1b2

chore: trigger unit tests [utest]

93ae135

chore: trigger unit tests [utest]

f33b330

chore: trigger unit tests [utest]

ee7869f

Delete unit-tests.yaml

5e32b80

Merge branch 'feature/CPD-32641-upgrade-zatca-to-laravel-13-v2' of gi…

d682bd5

…thub.com:SallaApp/ZATCA into feature/CPD-32641-upgrade-zatca-to-laravel-13-v2

chore: trigger unit tests [utest]

87be580

chore: trigger unit tests [utest]

6934543

chore: trigger unit tests [utest]

716f168

sallainternalbot Bot merged commit 715f042 into master Oct 6, 2026
4 checks passed

sallainternalbot Bot deleted the feature/CPD-32641-upgrade-zatca-to-laravel-13-v2 branch October 6, 2026 10:12

Conversation

thaifanisalla commented Sep 27, 2026 • edited by greptile-apps Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What kind of change does this PR introduce?

What is the current behaviour?

What is the new behaviour?

PHP requirement

Does this PR introduce a breaking change?

Follow-up

Related

Confidence Score: 5/5

Summary

Uh oh!

codacy-production Bot commented Sep 27, 2026

Up to standards ✅

Uh oh!

thaifanisalla commented Sep 27, 2026

Uh oh!

sallainternalbot Bot commented Sep 27, 2026

Unit Test Trigger Summary

Uh oh!

ahmed3mar commented Oct 6, 2026

Uh oh!

sallainternalbot Bot commented Oct 6, 2026 • edited by atlassian Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ Merge Blocked

I wasn't able to complete the merge due to the following issues:

👥 Missing Required Approvals

🎫 Missing or Invalid Ticket ID

⏰ Dependency PR Checks Are Stale

Uh oh!

EngRashaAmer commented Oct 6, 2026

Uh oh!

sallainternalbot Bot commented Oct 6, 2026

⚠️ Merge Blocked

I wasn't able to complete the merge due to the following issues:

⏰ Dependency PR Checks Are Stale

Uh oh!

EngRashaAmer commented Oct 6, 2026

Uh oh!

sallainternalbot Bot commented Oct 6, 2026

⚠️ Merge Blocked

I wasn't able to complete the merge due to the following issues:

⏰ Dependency PR Checks Are Stale

Uh oh!

EngRashaAmer commented Oct 6, 2026

Uh oh!

sallainternalbot Bot commented Oct 6, 2026

⚠️ Merge Blocked

I wasn't able to complete the merge due to the following issues:

⏰ Dependency PR Checks Are Stale

Uh oh!

thaifanisalla commented Oct 6, 2026

Uh oh!

sallainternalbot Bot commented Oct 6, 2026

Unit Test Trigger Summary

Uh oh!

codacy-production Bot commented Oct 6, 2026

Up to standards ✅

Uh oh!

Mustafa-Azzam-Salla commented Oct 6, 2026

Uh oh!

sallainternalbot Bot commented Oct 6, 2026

Unit Test Trigger Summary

Uh oh!

thaifanisalla commented Oct 6, 2026

Uh oh!

sallainternalbot Bot commented Oct 6, 2026

Unit Test Trigger Summary

Uh oh!

maqalaqil commented Oct 6, 2026

Uh oh!

Uh oh!

sallainternalbot Bot commented Oct 6, 2026

Uh oh!

sallainternalbot Bot commented Oct 6, 2026

Uh oh!

Reviewers

Assignees

Labels

thaifanisalla commented Sep 27, 2026 •

edited by greptile-apps Bot

Loading

sallainternalbot Bot commented Oct 6, 2026 •

edited by atlassian Bot

Loading