Faster relative score calculation - #34
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors RelativeResults.recalculate_relative_score for better performance by avoiding deepcopy, eliminating the per-user sort, and precomputing rank-based scores once per distinct absolute score via Counter. Also adds a test for the existing MIN-with-zero-score error path.
Changes:
- Replace
deepcopy(existing_scores)+appendwith list-spread to buildcase_scores. - Compute
best_scorefor MAX/MIN with a single pass instead of sorting; compute RANK scores once per unique value viaCounterand reuse for ties. - Add
test_calculate_min_relative_score_zero_new_scorecovering the MIN zero-scoreRuntimeError.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/ale_bench/data.py | Performance refactor of recalculate_relative_score; switches sort-based scoring to single-pass min/max and Counter-based rank computation. |
| tests/test_data.py | Adds a test for MIN relative-score-type rejecting a new score of 0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.