-
Notifications
You must be signed in to change notification settings - Fork 2
Add qartod and config #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
b74b7c6
Add qartod and config
madrichardson 976ffe4
Remove .DS_Store files
madrichardson 6f5f2a3
Address review comments
madrichardson 551b974
Add a notebook for qartod module functionality
madrichardson 57ff228
Add qartod and config
madrichardson 76da898
Remove .DS_Store files
madrichardson 8fa9b6a
Address review comments
madrichardson f3f1c75
Add a notebook for qartod module functionality
madrichardson 5035b2a
Update dependencies and authorship
madrichardson a6a226b
Update CHANGELOG with qartod module
madrichardson 0d3a53b
Add get_path_qartod_config function to paths module
madrichardson 5b2a811
Merge branch 'quarto-module' of https://github.com/madrichardson/esdg…
smwoodman a48a57a
Add qc plotting functions to plots.py and update qartod.py and qartod…
madrichardson 6a065bd
Update plots.py with color dictionary, add summary table function to …
madrichardson 1faa78a
Add notebook for using qc plots
madrichardson ff5489b
Update depth threshold to 1200
madrichardson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -27,6 +27,7 @@ dependencies: | |
| - folium | ||
| - skyfield | ||
| - timezonefinder | ||
| - ioos_qc | ||
|
|
||
| - pip: | ||
| - dbdreader | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,207 @@ | ||
| contexts: | ||
| - streams: | ||
|
|
||
| # ===================================================== | ||
| # POSITION | ||
| # ===================================================== | ||
|
|
||
| latitude: | ||
| qartod: | ||
| gross_range_test: | ||
| suspect_span: [-90, 90] | ||
| fail_span: [-90, 90] | ||
|
|
||
| longitude: | ||
| qartod: | ||
| gross_range_test: | ||
| suspect_span: [-180, 180] | ||
| fail_span: [-180, 180] | ||
|
|
||
| lat: | ||
| qartod: | ||
| gross_range_test: | ||
| suspect_span: [-90, 90] | ||
| fail_span: [-90, 90] | ||
|
|
||
| lon: | ||
| qartod: | ||
| gross_range_test: | ||
| suspect_span: [-180, 180] | ||
| fail_span: [-180, 180] | ||
|
|
||
| profile_lat: | ||
| qartod: | ||
| gross_range_test: | ||
| suspect_span: [-90, 90] | ||
| fail_span: [-90, 90] | ||
|
|
||
| profile_lon: | ||
| qartod: | ||
| gross_range_test: | ||
| suspect_span: [-180, 180] | ||
| fail_span: [-180, 180] | ||
|
|
||
| lat_uv: | ||
| qartod: | ||
| gross_range_test: | ||
| suspect_span: [-90, 90] | ||
| fail_span: [-90, 90] | ||
|
|
||
| lon_uv: | ||
| qartod: | ||
| gross_range_test: | ||
| suspect_span: [-180, 180] | ||
| fail_span: [-180, 180] | ||
|
|
||
| # ===================================================== | ||
| # PRESSURE / DEPTH | ||
| # ===================================================== | ||
|
|
||
| pressure: | ||
| qartod: | ||
| gross_range_test: | ||
| suspect_span: [0, 1000] | ||
| fail_span: [0, 6000] | ||
|
|
||
| spike_test: | ||
| suspect_threshold: 0.0 | ||
| fail_threshold: 0.0 | ||
|
|
||
| rate_of_change_test: | ||
| threshold: 0.1 | ||
|
|
||
| flat_line_test: | ||
| tolerance: 0.001 | ||
| suspect_threshold: 3000 | ||
| fail_threshold: 5000 | ||
|
|
||
| depth: | ||
| qartod: | ||
| gross_range_test: | ||
| suspect_span: [0, 1200] | ||
| fail_span: [0, 2000] | ||
|
|
||
| spike_test: | ||
| suspect_threshold: 0.0 | ||
| fail_threshold: 0.0 | ||
|
|
||
| rate_of_change_test: | ||
| threshold: 0.1 | ||
|
|
||
| # ===================================================== | ||
| # TEMPERATURE | ||
| # ===================================================== | ||
|
|
||
| temperature: | ||
| qartod: | ||
| gross_range_test: | ||
| suspect_span: [0, 35] | ||
| fail_span: [-2, 40] | ||
|
|
||
| spike_test: | ||
| suspect_threshold: 0.0 | ||
| fail_threshold: 0.0 | ||
|
|
||
| rate_of_change_test: | ||
| threshold: 0.1 | ||
|
|
||
| flat_line_test: | ||
| tolerance: 0.001 | ||
| suspect_threshold: 3000 | ||
| fail_threshold: 5000 | ||
|
|
||
| # ===================================================== | ||
| # CONDUCTIVITY | ||
| # ===================================================== | ||
|
|
||
| conductivity: | ||
| qartod: | ||
| gross_range_test: | ||
| suspect_span: [0, 6] | ||
| fail_span: [0, 9] | ||
|
|
||
| spike_test: | ||
| suspect_threshold: 0.0 | ||
| fail_threshold: 0.0 | ||
|
|
||
| rate_of_change_test: | ||
| threshold: 0.1 | ||
|
|
||
| flat_line_test: | ||
| tolerance: 0.001 | ||
| suspect_threshold: 3000 | ||
| fail_threshold: 5000 | ||
|
|
||
| # ===================================================== | ||
| # SALINITY | ||
| # ===================================================== | ||
|
|
||
| salinity: | ||
| qartod: | ||
| gross_range_test: | ||
| fail_span: [0, 42] | ||
| suspect_span: [10, 38] | ||
|
|
||
| spike_test: | ||
| suspect_threshold: 0.0 | ||
| fail_threshold: 0.0 | ||
|
|
||
| rate_of_change_test: | ||
| threshold: 0.1 | ||
|
|
||
| flat_line_test: | ||
| tolerance: 0.001 | ||
| suspect_threshold: 3000 | ||
| fail_threshold: 5000 | ||
|
|
||
| # ===================================================== | ||
| # DENSITY | ||
| # ===================================================== | ||
|
|
||
| density: | ||
| qartod: | ||
| gross_range_test: | ||
| fail_span: [1000, 1100] | ||
| suspect_span: null | ||
|
|
||
| spike_test: | ||
| suspect_threshold: 0.0 | ||
| fail_threshold: 0.0 | ||
|
|
||
| rate_of_change_test: | ||
| threshold: 0.1 | ||
|
|
||
| flat_line_test: | ||
| tolerance: 0.001 | ||
| suspect_threshold: 3000 | ||
| fail_threshold: 5000 | ||
|
|
||
| # ===================================================== | ||
| # VELOCITY | ||
| # ===================================================== | ||
|
|
||
| u: | ||
| qartod: | ||
| gross_range_test: | ||
| suspect_span: [-3, 3] | ||
| fail_span: [-10, 10] | ||
|
|
||
| spike_test: | ||
| suspect_threshold: 0.0 | ||
| fail_threshold: 0.0 | ||
|
|
||
| rate_of_change_test: | ||
| threshold: 0.1 | ||
|
|
||
| v: | ||
| qartod: | ||
| gross_range_test: | ||
| suspect_span: [-3, 3] | ||
| fail_span: [-10, 10] | ||
|
|
||
| spike_test: | ||
| suspect_threshold: 0.0 | ||
| fail_threshold: 0.0 | ||
|
|
||
| rate_of_change_test: | ||
| threshold: 0.1 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@madrichardson I'm curious about these spans for the Antarctic deployments. At depth, we'll see temperatures down at least to -1.5 C - see the attached plot. Can/should we either expand these spans, or have separate defaults for Antarctic/Pacific deployments?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question for other variables (different 'normal' ranges in the Antarctic vs Pacific), but I don't know enough about them to flag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just updated the qartod-config.yml to have the default values the glider dac people pointed me to, but we can definitely have separate defaults for Antarctic/Pacific deployments. The main function run_qartod_qc() can just point to a separate yml file, so we could have one for Antarctic and one for Pacific.
Ex:
run_qartod_qc(
input_file="deployment.nc",
output_file="deployment_qc.nc",
config_file="qartod-config-antarctic.yml",
)
run_qartod_qc(
input_file="deployment.nc",
output_file="deployment_qc.nc",
config_file="qartod-config-pacific.yml",
)